Repository navigation
C-195: feat(web): Add project dialog — machine, path, inspection result, create config, GitHub link - #404
Merged
AndreyBegma merged 6 commits intoOct 27, 2026
Conversation
…-add-project-dialog-machine-path # Conflicts: # apps/api/src/projects/projects.service.ts # apps/api/src/runner/runner-connections.service.ts # apps/api/src/runner/runner-socket.ts
…fig, GitHub link (#379) Replace the name-only create form and the inline bind form on the projects page with one Add project dialog. It picks a ready machine, inspects the typed folder after a 600 ms pause (stale answers dropped by sequence number), offers Create config for a folder without one, explains a refused folder with the allow command, and registers the project with an optional GitHub link. Rows link to the project's GitHub repository in a new tab.
…-add-project-dialog-machine-path
Signs in off camera, opens the Add project dialog from the Projects page and closes it with Escape. It touches only what renders on an empty account. Refs #379.
AndreyBegma
marked this pull request as ready for review
October 26, 2026 18:28
AndreyBegma
changed the base branch from
card/c196-feat-api-add-a-project-from-the-website
to
develop
October 27, 2026 08:14
…-add-project-dialog-machine-path
AndreyBegma
deleted the
card/c195-feat-web-add-project-dialog-machine-path
branch
October 27, 2026 10:05
AndreyBegma
restored the
card/c195-feat-web-add-project-dialog-machine-path
branch
October 27, 2026 10:17
AndreyBegma
deleted the
card/c195-feat-web-add-project-dialog-machine-path
branch
October 27, 2026 10:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
add-project.tsholds the dialog's rules as plain functions and a reducer: which machines can be chosen (online and announcingprojects), the preselected machine (the one of the latest run), the platform-style path placeholder, what an inspection means, folder error messages, GitHub URL and name checks, and a 600 ms debounced inspector. Every machine or path change takes a new sequence number and the reducer drops answers for any other, so a stale inspection is never shown.add-project.test.mjscovers it (17 tests).inspectFolder,initFolder,registerFolderfor the/projects/folders/*endpoints of feat(api): add a project from the website — machine, local path, GitHub link #378;Runner.features,Project.githubUrl; failures keep the APIcodeandprojectId.createProjectis gone.demoflow runner allow <dir>hint plus docs link when the path is not allowed, and "Open the existing project" on409 project-exists. Add registers with name and GitHub URL and opens the project. Focus starts on the machine field, Enter runs the primary action, Escape closes, and an aria-live region reads the state. Project rows show a GitHub link (target="_blank" rel="noopener noreferrer").projects.add.*andprojects.item.githubadded;projects.create/projects.bindremoved.demoflow/cards/C-195-…demo.json: signs in off camera, opens the dialog, closes it with Escape.Acceptance criteria
register()→registerFolder→router.push); reducer path covered by unit tests. Not exercised end to end: no paired machine in this environment.machineChoicetest plus the disabled options inmachine-field.tsx.project-list.tsx, checked by reading the code and the build.missing-env DEMO_LOGIN_EMAIL: the demo credentials are not set in this environment.Checks:
bunx tsc --noEmit(web),bun run check(Biome, 644 files),bun run testin web (109/109),bun run buildin web.Nautelle-Card: C-195