Ship licence text in the macOS and Linux archives - #7
Merged
Merged
Conversation
The Windows archive carries LICENSE.txt and a share/licenses tree because build_git_windows unpacks the Git SDK wholesale. The macOS and Linux builds compile from source into a minimal tree, so neither shipped any licence text -- the only licence-shaped file in either archive was gcm/NOTICE. Two additions. install_git_license copies git's COPYING to LICENSE.txt, since `make install` does not; these builds link system libraries rather than bundling them, so git's own terms are the whole set. bundle_gcm now fetches GCM's LICENSE from its pinned tag, because the release tarball carries the NOTICE that refers to the MIT text but not the text itself. Anchorpoint generates its third-party notices from these trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchorpoint generates its
THIRD-PARTY-LICENSES.txtfrom the licence text inside the git tree itbundles. The macOS and Linux archives contain none: the only licence-shaped file in either is
gcm/NOTICE.Windows never hit this because
build_git_windowsunpacks the Git SDK wholesale, which alreadycarries
LICENSE.txtand ashare/licensestree for the MSYS2 DLLs it bundles.build_git_macosand
build_git_linuxcompile from source into a minimal tree, andbuild.pyhas no licencehandling anywhere.
Two additions:
install_git_licensecopies git'sCOPYINGtoLICENSE.txt, whichmake installdoes notdo. These builds link system libraries (
-L/usr/lib, system curl,NO_PERL NO_TCLTK NO_GETTEXT)rather than bundling them, so unlike Windows there is no
share/licensesequivalent toreproduce — git's own terms are the whole set.
bundle_gcmnow fetches GCM'sLICENSEfrom its pinned tag. The release tarball ships theNOTICEthat refers to the MIT text but not the text itself, which is whygcm/NOTICEcurrentlystands alone. Verified
raw.githubusercontent.com/.../v2.8.0/LICENSEreturns 200 and its contentmatches the text Anchorpoint's notices already carry from the Windows tree.
python -m py_compile build.pypasses, matching thelint-build-scriptCI job.Not tested on a real macOS or Linux builder — I have no access to either. The next run of each
should confirm
LICENSE.txtandgcm/LICENSEare present in the staged tree before the archive ispublished.
Companion PRs:
ap2-external#1for the f3d half of the same gap, andanchorpoint2_private#390,which consumes both.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.