Skip to content

fix(ui): upload device hero images so they actually render #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmitRajput-Dev merged 1 commit into from
Oct 28, 2026
Merged

fix(ui): upload device hero images so they actually render #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Client/CrossPlatformGUI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#include "CrossPlatformGUI.h"

#include "imgui_internal.h" // ImGui::RegisterUserTexture()

#include <string>
#include <vector>
#include <algorithm>
Expand Down Expand Up @@ -317,8 +319,12 @@ const CrossPlatformGUI::DeviceTexture& CrossPlatformGUI::_deviceTexture(const st
ImTextureData* tex = IM_NEW(ImTextureData)();
tex->Create(ImTextureFormat_RGBA32, w, h);
memcpy(tex->GetPixels(), pixels, (size_t)w * h * 4);
tex->SetStatus(ImTextureStatus_WantCreate);
ImGui::GetPlatformIO().Textures.push_back(tex);
// ImGui::UpdateTexturesEndFrame() clears and rebuilds PlatformIO.Textures from the font atlases
// and the registered user textures on every frame, so pushing into it directly was dropped again
// before the renderer backend ever saw the WantCreate request: the hero image stayed blank in
// Release builds and tripped the "ImDrawCmd is referring to ImTextureData that wasn't uploaded"
// assert in Debug. RegisterUserTexture() is the supported way in (imgui >= 1.92).
ImGui::RegisterUserTexture(tex);

out.ref = tex->GetTexRef();
out.w = w;
Expand Down