feat(azure): Allow specifying the resource group#218
Draft
jaitaiwan wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Daniel J. Holmes (jaitaiwan) <dholmes@altinity.com>
1488264 to
10d0789
Compare
2977209 to
45e4e9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically, when deploying resources in Azure, the user is expected to provide a name of a resource group that is either in existence or will be created by the command.
E.g. for AKS:
Or for Azure RedHat Openshift:
When using our terraform templates, creating a resource group and attaching the service principal to it (reducing the scope of the role binds as a result) I cannot specify for the azure environment to use it. This changes that by allowing for the resource group to be specified.