Skip to content

refactoring for CRC32 to properly size calculation, #1472

Merged
Slach merged 1 commit into
masterfrom
hotfix_putMultipartCRC32
Jul 16, 2026
Merged

refactoring for CRC32 to properly size calculation, #1472
Slach merged 1 commit into
masterfrom
hotfix_putMultipartCRC32

Conversation

@Slach

@Slach Slach commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

fix #1471

@Slach
Slach merged commit e5aa742 into master Jul 16, 2026
54 of 56 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29508612509

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.3%) to 68.599%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: 8 uncovered changes across 1 file (29 of 37 lines covered, 78.38%).
  • 4 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
pkg/storage/s3.go 37 29 78.38%

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
pkg/clickhouse/clickhouse.go 2 79.04%
pkg/storage/sftp.go 2 61.49%

Coverage Stats

Coverage Status
Relevant Lines: 23945
Covered Lines: 16426
Line Coverage: 68.6%
Coverage Strength: 43534.13 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

putFileMultipartCRC32 silently truncates archived backups (declared size excludes tar overhead)

2 participants