Skip to content

refactor: remove unused DashboardAuthoringSession#382

Merged
BorisTyshkevich merged 1 commit into
mainfrom
refactor/remove-dashboard-authoring-session-349
Jul 22, 2026
Merged

refactor: remove unused DashboardAuthoringSession#382
BorisTyshkevich merged 1 commit into
mainfrom
refactor/remove-dashboard-authoring-session-349

Conversation

@BorisTyshkevich

Copy link
Copy Markdown
Collaborator

What & why

  • Delete the unused createDashboardAuthoringSession implementation and its dedicated unit suite before it gains a caller on the stale raw-repository commit path.
  • Remove the orphaned session-only DashboardCommandResult type and reconcile comments/changelog ownership around the surviving pure command pipeline.
  • Preserve workspace-semantics.ts per-file coverage in its owning unit suite after removing incidental session-test coverage.

Closes #349

Checklist

  • npm test passes (the per-file coverage gate is non-negotiable)
  • Tests added/updated in the same change as the code
  • npm run build succeeds (single-file dist/sql.html)
  • Layers kept honest: pure logic in src/core/, network in src/net/ (injected fetch), DOM in src/ui/
  • No new runtime dependency (or it is a deliberate, justified addition — see CONTRIBUTING)
  • README / CHANGELOG.md ([Unreleased]) updated if behavior or the deployed surface changed
  • Reconciled affected tracked work (roadmap Roadmap to 1.0.0 #68, the issue body, ADR/CHANGELOG) if this change reshaped it

Delete the unused authoring-session implementation, its dedicated tests, and its session-only result type before any production caller adopts the stale repository commit path.

Reconcile surviving command/layout documentation and retain model coverage in the owning workspace-semantics suite.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

Claude-Session: unavailable (OpenAI Codex)
@BorisTyshkevich
BorisTyshkevich merged commit 1912d3b into main Jul 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make DashboardAuthoringSession use the shared workspace mutation pipeline before adding callers

1 participant