fix(#370): keep Dashboard membership and stars consistent#380
Merged
Conversation
Make Dashboard tiles canonical for panel-query stars and route tile deletion through one atomic membership transform that cleans filter targets, preserves multi-instance membership, normalizes layouts, and mirrors spec.favorite. Add validation rollback, legacy/import, layout fallback, and real-browser Workbench-to-Dashboard reload coverage. Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: unavailable (OpenAI Codex)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Dashboard tile deletion now updates the complete workspace atomically: it removes the selected tile from explicit filter targets, derives the affected panel query’s compatibility
spec.favoriteflag from remaining tile instances, normalizes the active layout/fallback, and increments the Dashboard revision once through the existing commit path.Workbench panel-query stars and favorite-first ordering now read canonical
dashboard.tiles[]membership, so legacyfavorite: truerows without tiles render unstarred and repair themselves with one click. Filter/setup favorites retain their independent compatibility behavior, and imports never invent tiles.Tests cover final/multiple instances, target cleanup, validation and persistence rollback, legacy inconsistency, favorite imports, grid fallback normalization, and a real-browser Workbench star → Dashboard trash → page reload flow through the production renderers and IndexedDB repository on Chromium, Firefox, and WebKit.
Closes #370
Checklist
npm testpasses (5,013 tests; per-file coverage gate)npm run buildsucceeds (single-filedist/sql.html)src/dashboard/application/, DOM integration insrc/ui/CHANGELOG.md[Unreleased]updatedVerification
npm testnpm run buildnpm run test:e2e(264 passed; three unrelated Firefox navigation timeouts under full-suite saturation, all 14 affected specs passed on isolated rerun)playwright test tests/e2e/dashboard-membership.spec.js(Chromium, Firefox, WebKit: 3 passed)