test: warehouse connections — env-var loading and MongoDB auth detection

[anandgupta42]

What does this PR do?

1. loadFromEnv via Registry.load() — src/altimate/native/connections/registry.ts (5 new tests)

The loadFromEnv function parses ALTIMATE_CODE_CONN_* environment variables to configure database connections. This is the primary connection method for CI/CD pipelines, Docker containers, and Codespaces users. Zero unit tests existed for this code path — a parsing regression would silently break all env-var-based connections with no test signal.

New coverage includes:

• Valid JSON parsing from ALTIMATE_CODE_CONN_* env vars
• Connection name lowercasing from env var suffix (PROD_DB → prod_db)
• Graceful handling of invalid JSON (no crash, connection silently skipped)
• Rejection of configs missing the required type field
• Rejection of non-object JSON values (strings, numbers, arrays)

2. detectAuthMethod for MongoDB — src/altimate/native/connections/registry.ts (4 new tests)

MongoDB driver support was added in #482. The detectAuthMethod function has a MongoDB-specific branch (line 229) that returns "connection_string" when no password is present, or "password" when one is. This branch was completely untested. Auth method detection feeds into telemetry and provider UI — incorrect detection would cause misleading warehouse analytics.

New coverage includes:

• MongoDB without password → connection_string auth
• MongoDB with password → password auth
• mongo type alias (shorthand) without password → connection_string
• Explicit connection_string field takes precedence over MongoDB type fallback

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage from automated test discovery

How did you verify your code works?

bun test test/altimate/connections.test.ts          # 44 pass (39 existing + 5 new)
bun test test/altimate/warehouse-telemetry.test.ts  # 45 pass (41 existing + 4 new)

Marker check: bun run script/upstream/analyze.ts --markers --base main --strict — passed (no upstream-shared files modified).

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_015egWH6W5HdaVuMysv9tFHq

Summary by CodeRabbit

• Tests
  • Added test coverage for environment variable-based connection loading and validation.
  • Added unit tests for MongoDB authentication detection scenarios.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Two test files are enhanced with expanded unit test coverage: connections.test.ts gains env-var-based connection loading tests with proper cleanup logic, and warehouse-telemetry.test.ts adds MongoDB auth detection tests for the Registry.detectAuthMethod method.

Changes

Cohort / File(s)	Summary
Connection Loading Tests packages/opencode/test/altimate/connections.test.ts	Added afterEach import and new test suite covering env-var-based connection registration via Registry.load(), including validation of JSON parsing, invalid JSON handling, missing type field rejection, and per-test cleanup of saved env state.
Auth Detection Tests packages/opencode/test/altimate/warehouse-telemetry.test.ts	Added four synchronous unit tests for Registry.detectAuthMethod validating MongoDB auth method detection: connection string vs. password-based auth selection, support for both "mongodb" and "mongo" type aliases, and explicit connection_string field precedence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: eliminate 29 pre-existing test failures in CI #411: Modifies the same test file with related test infrastructure updates and connector testing adjustments.

Suggested labels

contributor

Poem

🐰 A rabbit hops through test-written halls,
Where env vars dance in connection calls,
MongoDB auth types now verified bright,
Cleanup logic keeps the state just right,
Coverage grows—the tests take flight! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the two main changes: env-var loading and MongoDB auth detection for warehouse connections.
Description check	✅ Passed	The description comprehensively covers what changed, why it matters, test coverage details, and how the author verified the changes. All required template sections (Summary, Test Plan, Checklist) are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260326-2211

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

packages/opencode/test/altimate/connections.test.ts (1)

84-87: Capture original env value only once in setEnv.

At Line 85, repeated calls with the same key in one test would overwrite the true original value and make restoration inaccurate. Consider guarding the first snapshot only.

♻️ Suggested tweak

 function setEnv(key: string, value: string) {
-  saved[key] = process.env[key]
+  if (!(key in saved)) saved[key] = process.env[key]
   process.env[key] = value
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/connections.test.ts` around lines 84 - 87,
The setEnv helper currently overwrites saved[key] each time it's called, losing
the true original environment value; modify setEnv (the function named setEnv)
to only capture and store process.env[key] into saved[key] if saved[key] is
undefined (i.e., guard the assignment so the original value is preserved on the
first call), then set process.env[key] to the new value as before so
tearDown/restore logic can accurately restore the original.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/opencode/test/altimate/warehouse-telemetry.test.ts`:
- Around line 186-188: The test for Registry.detectAuthMethod currently doesn't
distinguish the explicit connection_string branch from the MongoDB fallback
because the input lacks a password so both return "connection_string"; update
the test case used in the "prefers explicit connection_string field over mongodb
type fallback" test to include a password field (e.g., add password: "x") so
that the MongoDB fallback would produce a different result and the assertion
actually verifies precedence of the connection_string over the mongodb type
fallback.

---

Nitpick comments:
In `@packages/opencode/test/altimate/connections.test.ts`:
- Around line 84-87: The setEnv helper currently overwrites saved[key] each time
it's called, losing the true original environment value; modify setEnv (the
function named setEnv) to only capture and store process.env[key] into
saved[key] if saved[key] is undefined (i.e., guard the assignment so the
original value is preserved on the first call), then set process.env[key] to the
new value as before so tearDown/restore logic can accurately restore the
original.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3e30099f-c815-4ddc-93b8-a4c3f23c16cf

📥 Commits

Reviewing files that changed from the base of the PR and between abcaa1d and d5ec01b.

📒 Files selected for processing (2)

• packages/opencode/test/altimate/connections.test.ts
• packages/opencode/test/altimate/warehouse-telemetry.test.ts

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Precedence test does not currently differentiate the fallback path.

At Line 186, the input has no password, so MongoDB fallback also returns "connection_string". This test won’t catch precedence regressions. Add password to make the fallback outcome different.

✅ Make the assertion branch-distinguishing

 test("prefers explicit connection_string field over mongodb type fallback", () => {
-  expect(Registry.detectAuthMethod({ type: "mongodb", connection_string: "mongodb://localhost/test" } as any)).toBe("connection_string")
+  expect(
+    Registry.detectAuthMethod({
+      type: "mongodb",
+      password: "secret",
+      connection_string: "mongodb://localhost/test",
+    } as any),
+  ).toBe("connection_string")
 })

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	test("prefers explicit connection_string field over mongodb type fallback", () => {
	expect(Registry.detectAuthMethod({ type: "mongodb", connection_string: "mongodb://localhost/test" } as any)).toBe("connection_string")
	})
	test("prefers explicit connection_string field over mongodb type fallback", () => {
	expect(
	Registry.detectAuthMethod({
	type: "mongodb",
	password: "secret",
	connection_string: "mongodb://localhost/test",
	} as any),
	).toBe("connection_string")
	})

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/warehouse-telemetry.test.ts` around lines 186
- 188, The test for Registry.detectAuthMethod currently doesn't distinguish the
explicit connection_string branch from the MongoDB fallback because the input
lacks a password so both return "connection_string"; update the test case used
in the "prefers explicit connection_string field over mongodb type fallback"
test to include a password field (e.g., add password: "x") so that the MongoDB
fallback would produce a different result and the assertion actually verifies
precedence of the connection_string over the mongodb type fallback.

[anandgupta42]

Consolidated into #498. Tests deduplicated and merged into a single PR.