Low-hanging render performance improvements for logistics node & laptop - #90
Low-hanging render performance improvements for logistics node & laptop#90andrewsf wants to merge 1 commit into
Conversation
* Logistics node: remove fully occluded faces (44% reduction to 122) * Laptop: remove fully occluded faces (19% reduction to 208). Stripped pointless zero-rotation blocks (wasteful math) Does not affect any visuals: logistics node textures will retain the weird stretched look.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the laptop model’s cuboid rotations, directional faces, and UV mappings. Reformatted geometry and UV coordinate arrays in the logistics node item model while preserving its structure and texture references. ChangesLaptop model geometry
Logistics node model formatting
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CodeRabbit's entire summary is wrong. |
|
Thanks for this, this PR will be merged after my rewrite is complete |
|
@andrewsf will these be useful for me even in 121.1? Will these work the same? |
|
These model files, with and without my changes, should be valid for all Minecraft versions going all the way forward to the latest snapshot and backward to 1.8. (But you're using a deepslate break particle so really, 1.17). Still, I didn't boot up every version, so it could stand a sanity test if you backport. |
|
Thanks for that information, I will make the changes back and forth, just wanted to know if this is a specifically 26.1 thing. Thanks for the PR! |
Does not affect any visuals: logistics node textures will retain the weird stretched look.
Summary by CodeRabbit