Skip to content

Fix/icons#427

Merged
rugeli merged 2 commits intomainfrom
fix/icons
Apr 2, 2026
Merged

Fix/icons#427
rugeli merged 2 commits intomainfrom
fix/icons

Conversation

@rugeli
Copy link
Copy Markdown
Collaborator

@rugeli rugeli commented Mar 25, 2026

Problem

What is the problem this work solves, including
my guess is that sometime after #325, an SVGO dependency update or a related svg change started applying fill: currentColor as an inline style on <svg>.
Which made some icons look off:

Screenshot 2026-03-25 at 11 58 35 AM Screenshot 2026-03-25 at 11 58 42 AM Screenshot 2026-03-25 at 11 58 52 AM Screenshot 2026-03-25 at 11 58 59 AM

Solution

What I/we did to solve this problem

  • added fill: none to button icons and the cert icon in modal and table modules

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  • add link to preview here
  • go to the preview site, hover over icons across pages, especially in disease table and parental line modal. They should render and behave as expected

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for cell-catalog ready!

Name Link
🔨 Latest commit b52fa0f
🔍 Latest deploy log https://app.netlify.com/projects/cell-catalog/deploys/69c454318937f60008eeb4a1
😎 Deploy Preview https://deploy-preview-427--cell-catalog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rugeli rugeli requested review from interim17 and meganrm March 25, 2026 21:41
Copy link
Copy Markdown
Contributor

@interim17 interim17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@rugeli rugeli merged commit 8cb7daa into main Apr 2, 2026
7 checks passed
@rugeli rugeli deleted the fix/icons branch April 2, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants