feature/lefthook #417
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| output: | ||
| - summary | ||
| - failure | ||
| pre-commit: | ||
| parallel: true | ||
| jobs: | ||
| - name: format | ||
| glob: "**/*.{ts,tsx,json}" | ||
| run: yarn --silent format:files {staged_files} | ||
| stage_fixed: true | ||
|
|
||
| - name: lint | ||
| glob: "**/*.{ts,tsx}" | ||
| run: yarn --silent lint:files {staged_files} | ||
| stage_fixed: true | ||
|
Comment on lines
+5
to
+15
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment. Without having looked into it this seems like a good thing to implement. I noticed some duplicate warnings and wonder if the parallel execution was leading to that. |
||
|
|
||
| - name: typecheck | ||
| run: yarn --silent typeCheck --pretty false | ||
|
|
||
| - name: test | ||
| run: yarn --silent test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,87 +1,91 @@ | ||
| { | ||
| "name": "cell-catalog", | ||
| "description": "Cell catalog for Allen Institute for Cell Science", | ||
| "version": "1.3.1", | ||
| "author": "Megan Riel-Mehan", | ||
| "license": "MIT", | ||
| "main": "n/a", | ||
| "dependencies": { | ||
| "@ant-design/icons": "^5.5.1", | ||
| "@reach/router": "^1.3.4", | ||
| "@svgr/webpack": "^8.1.0", | ||
| "antd": "^5.21.2", | ||
| "decap-cms-app": "^3.6.3", | ||
| "decap-cms-media-library-cloudinary": "^3.0.1", | ||
| "decap-cms-media-library-uploadcare": "^3.0.0", | ||
| "gatsby": "^5.14.0-next.3", | ||
| "gatsby-plugin-decap-cms": "^4.0.3", | ||
| "gatsby-plugin-fix-fouc": "^1.0.5", | ||
| "gatsby-plugin-image": "^3.14.0", | ||
| "gatsby-plugin-netlify": "^5.1.1", | ||
| "gatsby-plugin-nprogress": "^5.15.0", | ||
| "gatsby-plugin-purgecss": "^6.0.0", | ||
| "gatsby-plugin-react-helmet": "^6.13.1", | ||
| "gatsby-plugin-react-svg": "^3.3.0", | ||
| "gatsby-plugin-sass": "^6.13.1", | ||
| "gatsby-plugin-sharp": "^5.13.1", | ||
| "gatsby-plugin-svgr-svgo": "^2.0.0", | ||
| "gatsby-remark-copy-linked-files": "^6.13.1", | ||
| "gatsby-remark-external-links": "^0.0.4", | ||
| "gatsby-remark-images": "^7.14.0", | ||
| "gatsby-remark-line-breaks": "^1.0.0", | ||
| "gatsby-remark-relative-images": "^2.0.5", | ||
| "gatsby-source-filesystem": "^5.13.1", | ||
| "gatsby-transformer-remark": "^6.13.1", | ||
| "gatsby-transformer-remark-frontmatter": "^1.1.0", | ||
| "gatsby-transformer-sharp": "^5.13.1", | ||
| "lodash": "^4.17.15", | ||
| "lodash-webpack-plugin": "^0.11.4", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-helmet": "^6.0.0", | ||
| "sass": "^1.43.2", | ||
| "uuid": "^8.0.0", | ||
| "vitest": "^4.0.17" | ||
| }, | ||
| "keywords": [ | ||
| "gatsby" | ||
| ], | ||
| "scripts": { | ||
| "clean": "gatsby clean", | ||
| "start": "npm run develop", | ||
| "build": "npm run clean && gatsby build", | ||
| "develop": "npm run clean && gatsby develop", | ||
| "serve": "gatsby serve", | ||
| "format": "prettier \"src/**/*{.tsx, .ts}\" package.json --write", | ||
| "format:files": "prettier --write", | ||
| "formatCheck": "prettier \"src/**/*{.tsx, .ts}\" package.json --check", | ||
| "lint": "eslint \"src/**/*{.tsx, .ts}\" --quiet --fix", | ||
| "lint:files": "eslint --quiet --fix", | ||
| "test": "vitest run", | ||
| "dev": "npx concurrently \"npx netlify-cms-proxy-server\" \"npm start -- --progress\"", | ||
| "typeCheck": "tsc --noEmit", | ||
| "prepare": "lefthook install" | ||
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^9.38.0", | ||
| "@trivago/prettier-plugin-sort-imports": "^5.2.2", | ||
| "@types/antd": "^1.0.0", | ||
| "@types/node": "^20.11.20", | ||
| "@types/react": "^18.2.59", | ||
| "@types/react-dom": "^18.2.19", | ||
| "@types/react-helmet": "^6.1.11", | ||
| "concurrently": "^9.1.2", | ||
| "eslint": "^9.38.0", | ||
| "eslint-plugin-react": "^7.37.5", | ||
| "eslint-plugin-sort-destructure-keys": "^2.0.0", | ||
| "gatsby-plugin-postcss": "^6.13.1", | ||
| "globals": "^16.4.0", | ||
| "jiti": "^2.6.1", | ||
| "lefthook": "^2.0.15", | ||
| "netlify-cli": "^17.15.7", | ||
| "postcss": "^8.4.35", | ||
| "prettier": "^3.6.2", | ||
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.46.2", | ||
| "typescript-plugin-css-modules": "^5.1.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 22.16.0" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a bunch of experiments (switching commands with npx, adding
fail_textas a job field, tweaking parameters etc. Here's update:Show Command Outputview can be cleaned up usingexecution_info, this removes the extra blocks and special characters. Now the outputs looks much better.these are the changes in this file that seemed useful during testing (I didn't submit a sub-pr since the changes are small and not yet optimal):
let me know what you think. I can work on this more and open a sub-pr if I find a better fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I don't feel precious about this branch and I'm also fine to walk away from this feature if it's taking a lot of time or energy, I don' think it's high priority.
Feel free to commit to this branch or open new branches.