feat: add helm chart for training-operator#3
Draft
vicoooo26 wants to merge 3 commits into
Draft
Conversation
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
vicoooo26
force-pushed
the
feat/helm-chart
branch
from
July 20, 2026 10:40
21f107a to
62e1608
Compare
Signed-off-by: Vico Chu <vico24826@gmail.com>
vicoooo26
force-pushed
the
feat/helm-chart
branch
from
July 20, 2026 11:26
62e1608 to
d307513
Compare
Signed-off-by: Vico Chu <vico24826@gmail.com>
cheyang
reviewed
Jul 23, 2026
cheyang
left a comment
Collaborator
There was a problem hiding this comment.
Early feedback (still a draft). The templates are in good shape — the fail guard on replicas>1 without leader election, the probes, the security context, and values.schema.json (incl. the min/maxUnavailable mutual-exclusion) are all nice; helm lint is clean and helm template renders. A few things stood out, mostly from a first-run user’s perspective:
- The PR description says “cert-manager integration”, but the chart doesn’t use cert-manager (no Certificate/Issuer, no caBundle / inject annotation). It relies on the operator’s built-in self-signed cert written into an empty Secret and patching the webhook
caBundleat runtime (hence thevalidatingwebhookconfigurations: updategrant). Worth correcting the description. - The README install commands reference the
aliyun-incubator/training-operatorrepo, but there’s nohelm repo add aliyun-incubator <url>step — the documented install won’t work as written. - Minor: CRDs under
crds/aren’t upgraded by Helm; a note in the README about applying CRD updates manually would help.
…and update chart meta info
vicoooo26
force-pushed
the
feat/helm-chart
branch
from
July 23, 2026 11:51
481409e to
e608563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a Helm chart for deploying the training-operator on Kubernetes. The chart includes all necessary CRDs (TFJob, PyTorchJob, JAXJob, MPIJob, PaddleJob, XGBoostJob), RBAC resources, webhook configuration, and configurable values for production deployments.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Checklist: