Skip to content

feat: add helm chart for training-operator#3

Draft
vicoooo26 wants to merge 3 commits into
AliyunContainerService:developfrom
vicoooo26:feat/helm-chart
Draft

feat: add helm chart for training-operator#3
vicoooo26 wants to merge 3 commits into
AliyunContainerService:developfrom
vicoooo26:feat/helm-chart

Conversation

@vicoooo26

@vicoooo26 vicoooo26 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Add a Helm chart for deploying the training-operator on Kubernetes. The chart includes all necessary CRDs (TFJob, PyTorchJob, JAXJob, MPIJob, PaddleJob, XGBoostJob), RBAC resources, webhook configuration, and configurable values for production deployments.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Checklist:

  • Docs included if any changes are user facing

@github-actions

Copy link
Copy Markdown

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Signed-off-by: Vico Chu <vico24826@gmail.com>
Signed-off-by: Vico Chu <vico24826@gmail.com>

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early feedback (still a draft). The templates are in good shape — the fail guard on replicas>1 without leader election, the probes, the security context, and values.schema.json (incl. the min/maxUnavailable mutual-exclusion) are all nice; helm lint is clean and helm template renders. A few things stood out, mostly from a first-run user’s perspective:

  • The PR description says “cert-manager integration”, but the chart doesn’t use cert-manager (no Certificate/Issuer, no caBundle / inject annotation). It relies on the operator’s built-in self-signed cert written into an empty Secret and patching the webhook caBundle at runtime (hence the validatingwebhookconfigurations: update grant). Worth correcting the description.
  • The README install commands reference the aliyun-incubator/training-operator repo, but there’s no helm repo add aliyun-incubator <url> step — the documented install won’t work as written.
  • Minor: CRDs under crds/ aren’t upgraded by Helm; a note in the README about applying CRD updates manually would help.

Comment thread charts/training-operator/values.yaml Outdated
Comment thread charts/training-operator/templates/tests/test-connection.yaml Outdated
Comment thread charts/training-operator/Chart.yaml Outdated
@vicoooo26
vicoooo26 changed the base branch from release-1.9 to develop July 24, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants