Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test-train-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:

- name: Run tests
run: |
pip install pytest
pip install pytest "kubernetes<36"
python3 -m pip install -e sdk/python[huggingface]
pytest -s sdk/python/test/e2e-fine-tune-llm/test_e2e_pytorch_fine_tune_llm.py --log-cli-level=debug
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:

- name: Run tests
run: |
pip install pytest
pip install pytest "kubernetes<36"
python3 -m pip install -e sdk/python; pytest -s sdk/python/test/e2e --log-cli-level=debug --namespace=default
env:
GANG_SCHEDULER_NAME: ${{ matrix.gang-scheduler-name }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-example-notebooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Install Python Dependencies
run: |
pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5
pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5 "kubernetes<36"

- name: Run Jupyter Notebook with Papermill
shell: bash
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/test-python.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ jobs:

- name: Install dependencies
run: |
pip install pytest python-dateutil urllib3 kubernetes
# TODO: kubernetes 36.0.0 switched to Pydantic models, breaking the
# FakeResponse deserialization hack in the SDK unit tests. To remove
# this pin, either adapt FakeResponse in
# sdk/python/kubeflow/training/utils/utils.py for Pydantic or mock
# ApiClient.deserialize directly in the test suite.
pip install pytest python-dateutil urllib3 "kubernetes<36"
pip install -U './sdk/python[huggingface]'

- name: Run unit test for training sdk
Expand Down
12 changes: 7 additions & 5 deletions build/images/kubectl-delivery/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
FROM alpine:3.17 AS build
ARG ALPINE_VERSION=3.22

ARG TARGETARCH
FROM alpine:${ALPINE_VERSION} AS build

# Install kubectl.
ENV K8S_VERSION v1.30.7
ARG TARGETARCH
ARG K8S_VERSION=v1.30.7

RUN apk add --no-cache wget
RUN wget -q https://dl.k8s.io/release/${K8S_VERSION}/bin/linux/${TARGETARCH}/kubectl
RUN wget -q https://dl.k8s.io/release/${K8S_VERSION}/bin/linux/${TARGETARCH}/kubectl.sha256
RUN test "$(cat kubectl.sha256)" = "$(sha256sum kubectl | cut -d' ' -f1)"
RUN chmod +x ./kubectl
RUN mv ./kubectl /bin/kubectl

FROM alpine:3.17
FROM alpine:${ALPINE_VERSION}
COPY --from=build /bin/kubectl /bin/kubectl
RUN apk add --no-cache bash

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/test/e2e/test_e2e_jaxjob.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,5 +156,5 @@ def generate_container() -> V1Container:
return V1Container(
name=CONTAINER_NAME,
image=os.getenv("JAX_JOB_IMAGE", "docker.io/kubeflow/jaxjob-dist-spmd-mnist:latest"),
resources=V1ResourceRequirements(limits={"memory": "3Gi", "cpu": "1.2"}),
resources=V1ResourceRequirements(limits={"memory": "5Gi", "cpu": "1.2"}),
)
Loading