Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ final class CombinedReleaseRegistrar {
if (!release.resumeId.getOrElse('') && release.useExistingBundle.getOrElse(false)) {
// Bind upload evidence only for an upload graph, never plain checks/bundling.
// This input is retained when the configuration cache stores the resolved graph.
// Keep the cached-graph regressions when upgrading Gradle: this relies on
// task inputs remaining writable during graph configuration.
guardTask.get().expectedManifestSha256.set(release.expectedManifestSha256)
}
} else {
project.logger.info('Upload evidence ignored: releaseAll not scheduled')
}
if (graph.hasTask(releasePath) && graph.hasTask(bundlePath)) {
ReleaseAllTask release = releaseAllTask.get()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
import java.util.zip.ZipFile
import static org.junit.jupiter.api.Assertions.*
import static org.gradle.testkit.runner.TaskOutcome.SUCCESS

class ModuleReleaseTest {
private static final String BUNDLE = 'build/releaseAll/module-release-fixture-mega-bundle.zip'
Expand Down Expand Up @@ -707,16 +708,19 @@ nexusReleasePlugin {
}

@ParameterizedTest
@ValueSource(strings = ['bundleAll', 'releaseAllSigningCheck', 'releaseAllGuard', ':core:check'])
@ValueSource(strings = ['bundleAll', 'releaseAllSigningCheck', 'releaseAllGuard'])
void nonUploadGraphsIgnoreExportedUploadEvidence(String task) {
withServer { String base, List requests ->
existingFixture(base)
run('releaseAllPlan')
String[] args = ['-Pexisting', '-Pexpected=not-an-upload-digest', '-PexpectedManifest=not-a-manifest-digest']
String[] args = ['-Pexisting', '-Pexpected=not-an-upload-digest', '-PexpectedManifest=not-a-manifest-digest', '--info']
def first = run(task, *args)
assertNull(first.task(':releaseAll'))
assertEquals(SUCCESS, first.task(':releaseAllGuard')?.outcome)
assertTrue(first.output.contains('Upload evidence ignored: releaseAll not scheduled'))
def cached = run(task, *args)
assertNull(cached.task(':releaseAll'))
assertEquals(SUCCESS, cached.task(':releaseAllGuard')?.outcome)
assertTrue(cached.output.contains('Reusing configuration cache.'))
assertFalse(requests.any { it.contains('/publisher/upload') })
}
Expand Down
Loading