Skip to content

Warn when preview_account_update touches closed fiscal years - #142

Merged
perNyfelt merged 5 commits into
mainfrom
feature/account-update-closed-year-warning
Nov 14, 2026
Merged

perNyfelt merged 5 commits into
mainfrom
feature/account-update-closed-year-warning

Conversation

@perNyfelt

Copy link
Copy Markdown
Member

Summary

  • AccountService.summarizeAccountUsage now also returns closedFiscalYearCount (distinct closed fiscal years with posted activity on the account).
  • preview_account_update returns closed_fiscal_year_count in usage and, when greater than zero, a warning: the reclassification changes the reports for those years after the fact. The error path also returns an empty warnings list so clients can rely on the key.
  • The account-update handlers, preview-token ledger and per-account write sequence moved from AccountingMcpTools into a new AccountUpdateMcpSupport class; the addition tipped the dispatcher past the CodeNarc ClassSize limit. Token semantics are unchanged.
  • Tool description, skill/accounting-mcp.md (reclassify-account workflow) and the v1.9.0 release notes are updated — the release notes also cover the other merged PRs and the upgrade notes (breaking result_account_count MCP change, closed years not corrected, legal-form default closing account, HB/KB manual split).

Test plan

  • New integration tests: summarizeAccountUsageCountsOnlyClosedFiscalYears (vouchers in one locked + one open year) and previewAccountUpdateWarnsWhenAccountIsUsedInClosedFiscalYears, plus assertions that an open year yields no warning.
  • ./gradlew build passed: 874 tests, 0 failures, 11 skipped (Spotless and CodeNarc clean).

@perNyfelt
perNyfelt merged commit 9325e96 into main Nov 14, 2026
3 checks passed
@perNyfelt
perNyfelt deleted the feature/account-update-closed-year-warning branch November 14, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant