Repository navigation
Warn when preview_account_update touches closed fiscal years - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountService.summarizeAccountUsagenow also returnsclosedFiscalYearCount(distinct closed fiscal years with posted activity on the account).preview_account_updatereturnsclosed_fiscal_year_countinusageand, when greater than zero, a warning: the reclassification changes the reports for those years after the fact. The error path also returns an emptywarningslist so clients can rely on the key.AccountingMcpToolsinto a newAccountUpdateMcpSupportclass; the addition tipped the dispatcher past the CodeNarc ClassSize limit. Token semantics are unchanged.skill/accounting-mcp.md(reclassify-account workflow) and the v1.9.0 release notes are updated — the release notes also cover the other merged PRs and the upgrade notes (breakingresult_account_countMCP change, closed years not corrected, legal-form default closing account, HB/KB manual split).Test plan
summarizeAccountUsageCountsOnlyClosedFiscalYears(vouchers in one locked + one open year) andpreviewAccountUpdateWarnsWhenAccountIsUsedInClosedFiscalYears, plus assertions that an open year yields no warning../gradlew buildpassed: 874 tests, 0 failures, 11 skipped (Spotless and CodeNarc clean).