Repository navigation
Cover in-memory fiscal-year and VAT operations after H2 fix - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiscal-year creation in in-memory test databases was blocked by H2 2.4.240's constant-list CHECK regression. The H2 upgrade to 2.5.252 in #127 already resolved the underlying bug, but the audit-log test still bypassed fiscal-year and VAT-period creation with a direct insert.
This removes that workaround, documents the supported operations in
TestDatabaseUrls, and adds an integration regression test that creates a fiscal year, verifies accounting/VAT periods, and reports a VAT period after the schema-creating connection has closed. VAT rows are counted directly before callinglistPeriods, ensuring the test detects missing period creation increateFiscalYear. It also checks persisted status, report validity, and audit-chain integrity. The regression test and audit-log test fixture explicitly shut down their in-memory databases; helper documentation describes the covered VAT constraint and the historical H2 fix.Validation:
DatabaseServiceTestandAuditLogServiceTestpassed with H2 2.5.252.CK_VAT_PERIOD_STATUS/ closed-database error../gradlew spotlessApplyand./gradlew codenarcMainpassed../gradlew buildpassed: 838 tests, zero failures or errors, 11 skipped; Spotless and CodeNarc passed.Only test code and test-helper documentation change; no production, schema, or migration impact.
Closes #129.