Repository navigation
Improve voucher toolbar with consistent SVG controls - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The voucher editor uses Lucide SVG icons with a labelled primary Save button and consistent command sizing. The after-save mode has a visible, translated On/Off label and the theme's ordinary toggle styling, so its state can be read without relying on color.
Button.disabledText, without applying an additional grayscale filter. Selected toggles use the theme's shared toggle foreground.Validation:
./gradlew spotlessApply,./gradlew codenarcMain codenarcTest, and./gradlew build: 820 tests, zero failures, 11 skipped.No schema or migration changes. Screenshots are headless Swing renders using isolated test data. Image URLs are pinned to a commit so branch deletion after merge will not break them.
macOS, light:

macOS, dark:

Windows 11 ARM64, light:

Windows 11 ARM64, dark:

Windows, registered voucher with disabled Save and after-save mode off:

Windows, Swedish toolbar at a 600 px window width:

Additional macOS renders: registered voucher, wrapped Swedish toolbar.
Fixes #125.