Skip to content

[PWGLF] Fix code-checker problems in flattenictyPikp.cxx#16908

Merged
gbencedi merged 2 commits into
AliceO2Group:masterfrom
gbencedi:master
Jul 3, 2026
Merged

[PWGLF] Fix code-checker problems in flattenictyPikp.cxx#16908
gbencedi merged 2 commits into
AliceO2Group:masterfrom
gbencedi:master

Conversation

@gbencedi

@gbencedi gbencedi commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 2, 2026
@github-actions github-actions Bot changed the title Fix code-checker problems [PWGLF] Fix code-checker problems Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 64d59c8 at 2026-07-02 23:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 0 warnings.'
Found 7 errors and 0 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/9ea0bca7ddb70ec463b613d148d0c24078343b50/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:72:1: error: included header cstdint is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1865:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1871:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1877:46: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2187:51: error: the parameter 'h' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2211:51: error: the parameter 'num' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2211:61: error: the parameter 'den' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@gbencedi gbencedi marked this pull request as draft July 2, 2026 21:10
@vkucera

vkucera commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@gbencedi Thanks for the fixes. Please add the where in the PR title.

@gbencedi gbencedi changed the title [PWGLF] Fix code-checker problems [PWGLF] Fix code-checker problems in flattenictyPikp.cxx Jul 3, 2026
@gbencedi gbencedi marked this pull request as ready for review July 3, 2026 19:09
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for de21e32 at 2026-07-03 21:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/f2d0d0f0aeb006c9e46ff1ea67d1faaeeed39fa4/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1864:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1870:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1876:46: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@gbencedi gbencedi enabled auto-merge (squash) July 3, 2026 19:32

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @gbencedi.

@gbencedi gbencedi merged commit 14a30fa into AliceO2Group:master Jul 3, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants