Skip to content

[PWGEM/Dilepton] update taskV1#16903

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master
Jul 2, 2026
Merged

[PWGEM/Dilepton] update taskV1#16903
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

@dsekihat dsekihat commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton]: update taskV1

@github-actions github-actions Bot added the pwgem label Jul 2, 2026
@github-actions github-actions Bot changed the title [PWGEM/Dilepton]: update taskV1 [PWGEM/Dilepton] update taskV1 Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 40 errors, ⚠️ 75 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4ab0332 at 2026-07-02 15:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 0 warnings.'
Found 14 errors and 0 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/323408e9faf522f5218c91049ef57fe5aae27f39/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Tasks/dimuonV1.cxx:21:1: error: included header EMTrack.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:22:1: error: included header EMTrackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:25:1: error: included header PairUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:32:1: error: included header LHCConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:33:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:48:1: error: included header Utils.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:52:1: error: included header TString.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:54:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:58:1: error: included header chrono is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:60:1: error: included header cstddef is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:70:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:183:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:212:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:494:129: error: no header providing "o2::aod::fwdtrack::ForwardTrackTypeEnum" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 14 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera
vkucera reviewed Jul 2, 2026
View reviewed changes
Comment thread PWGEM/Dilepton/Tasks/dimuonV1.cxx
Comment on lines +319 to +320
ROOT::Math::PtEtaPhiMVector v1(t1.pt(), t1.eta(), RecoDecay::constrainAngle(t1.phi(), 0, 1U), o2::constants::physics::MassMuon);
ROOT::Math::PtEtaPhiMVector v2(t2.pt(), t2.eta(), RecoDecay::constrainAngle(t2.phi(), 0, 1U), o2::constants::physics::MassMuon);

@vkucera vkucera Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values are redundant.

@alibuild

alibuild commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a79ba6b at 2026-07-02 16:52:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 0 warnings.'
Found 14 errors and 0 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/3b21cab96faed53613479d4cd6daa73b254fdd07/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Tasks/dimuonV1.cxx:21:1: error: included header EMTrack.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:22:1: error: included header EMTrackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:25:1: error: included header PairUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:32:1: error: included header LHCConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:33:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:48:1: error: included header Utils.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:52:1: error: included header TString.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:54:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:58:1: error: included header chrono is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:60:1: error: included header cstddef is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:70:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:183:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:212:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:494:129: error: no header providing "o2::aod::fwdtrack::ForwardTrackTypeEnum" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 14 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat dsekihat enabled auto-merge (squash) July 2, 2026 15:33
alibuild
alibuild approved these changes Jul 2, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit d97d0db into AliceO2Group:master Jul 2, 2026
13 of 16 checks passed
@vkucera

vkucera commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@dsekihat Please do not merge PRs with errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild alibuild approved these changes
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsekihat @alibuild @vkucera