[PWGCF] added some more efficiency histograms by nidamalikk · Pull Request #16900 · AliceO2Group/O2Physics

nidamalikk · 2026-07-02T09:43:55Z

No description provided.

github-actions · 2026-07-02T09:56:19Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-07-02T10:08:13Z

Error while checking build/O2Physics/code-check for d35cf80 at 2026-07-02 12:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 70 warnings.'
Found 18 errors and 70 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/ad2a712c6abcf331d59a53201552bb779c87d862/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:61:8: error: constructor does not initialize these fields: pdgService, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:65:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:406:49: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:413:50: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:421:54: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:428:55: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:437:52: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:444:53: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:452:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:453:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:454:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:863:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:946:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1061:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1147:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1271:16: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1286:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1361:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/ad2a712c6abcf331d59a53201552bb779c87d862/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:466:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:468:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:474:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:476:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:482:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:484:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:495:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:520:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:522:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:524:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:526:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:528:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:530:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:567:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:569:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:571:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:573:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:575:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:577:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:579:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:581:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:583:52: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild · 2026-07-02T10:19:48Z

Error while checking build/O2Physics/code-check for 14475d4 at 2026-07-02 12:19:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 70 warnings.'
Found 18 errors and 70 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/c2766c40f54bc26ed4d0484d0f41c107a3ebf145/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:61:8: error: constructor does not initialize these fields: pdgService, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:65:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:406:49: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:413:50: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:421:54: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:428:55: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:437:52: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:444:53: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:452:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:453:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:454:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:863:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:946:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1061:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1147:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1271:16: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1286:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1361:16: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/c2766c40f54bc26ed4d0484d0f41c107a3ebf145/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:466:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:468:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:474:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:476:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:482:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:484:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:495:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:520:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:522:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:524:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:526:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:528:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:530:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:567:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:569:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:571:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:573:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:575:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:577:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:579:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:581:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:583:52: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild · 2026-07-02T11:12:22Z

Error while checking build/O2Physics/code-check for 10318ba at 2026-07-02 13:12:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 9 errors and 33 warnings.'
Found 9 errors and 33 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/a4ea4af02137683288c3ac666a572dd91b36de8b/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:66:22: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:453:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:454:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:869:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:957:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1079:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1171:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1315:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1392:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 33 -gt 0 ]]
++ cat /sw/BUILD/a4ea4af02137683288c3ac666a572dd91b36de8b/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:466:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:468:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:474:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:476:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:482:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:484:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:495:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:520:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:522:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:524:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:526:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:528:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:530:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:567:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:569:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:571:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:573:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:575:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:577:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:579:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:581:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:583:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:585:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1272:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1274:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1276:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1278:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1280:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1282:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1284:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1286:32: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

SwatiSaha-1997 · 2026-07-02T11:59:38Z

Hi @nidamalikk, there are these errors in you PR, would you kindly look at them and fix.

nidamalikk · 2026-07-02T13:48:39Z

Hi @nidamalikk, there are these errors in you PR, would you kindly look at them and fix.

Hello Swati di, I hope it is fixed now. Thank Youuu.

alibuild · 2026-07-02T13:55:33Z

Error while checking build/O2Physics/code-check for bbe2239 at 2026-07-02 15:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 10 warnings.'
Found 4 errors and 10 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/6657ebdc22dc2188b7deb0c437405616ad184a4b/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:887:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1190:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1334:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1411:16: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/6657ebdc22dc2188b7deb0c437405616ad184a4b/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1291:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1293:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1295:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1297:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1299:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1301:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1303:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1305:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1307:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/netchargeFluctuations.cxx:1309:32: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

SwatiSaha-1997 · 2026-07-02T15:04:27Z

Dear @vkucera, could you please look into it, if anything can be done to bring the git host back.

vkucera · 2026-07-02T15:07:51Z

@SwatiSaha-1997 Where do you see that? A link would be better than a screenshot.

SwatiSaha-1997 · 2026-07-02T15:09:40Z

@SwatiSaha-1997 Where do you see that? A link would be better than a screenshot.

Dear @vkucera , please find the link https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/O2Physics/16900/1567c10dbad9016d92b35ea6b85eece4ec5da5ff/build_O2Physics_o2_macOS/pretty.html
I got it by clicking on build/O2Physics/o2/macOS check that has failed

vkucera · 2026-07-02T15:10:39Z

@SwatiSaha-1997 Please ignore the macOS build. It always fails.

SwatiSaha-1997 · 2026-07-02T15:11:53Z

@SwatiSaha-1997 Please ignore the macOS build. It always fails.

Thank you very much @vkucera . So, I can approve this PR as all other checks have passed.

vkucera · 2026-07-02T15:15:01Z

@SwatiSaha-1997 But the title is too vague.

nidamalikk added 20 commits September 28, 2025 18:02

added histograms for multiplicity correlation plots

6fa3e58

use different polynomial for fitting multiplicity correlation plots

4fda1aa

use different polynomial for fitting multiplicity correlation plots

e18f2f8

PWGCF-removal of outliers

128f502

Merge branch 'master' of github.com:nidamalikk/O2Physics

b17fdf3

Net charge

457c3d0

Net charge

0cedf77

Merge branch 'master' into master

bfbeadc

Net charge

b392003

Net charge

408485c

Net charge

3bd0499

Net charge

5ece446

Net charge

f00c89e

Net charge

0e27b59

Add netchargeFluctuations task

66d73ce

Add netchargeFluctuations task

abb255b

Add netchargeFluctuations task

a915273

Add netchargeFluctuations task

50b8e52

Merge branch 'AliceO2Group:master' into master

f739d4c

Added some eff histograms

1e903b6

nidamalikk requested review from SwatiSaha-1997, alibuild, isputows, lauraser, shouqiye and victor-gonzalez as code owners July 2, 2026 09:43

github-actions Bot added the pwgcf label Jul 2, 2026

github-actions Bot changed the title ~~added some more efficiency histograms~~ [PWGCF] added some more efficiency histograms Jul 2, 2026

alibuild mentioned this pull request Jul 2, 2026

[PWGCF] Please consider the following formatting changes to #16900 nidamalikk/O2Physics#19

Closed

Added some eff histograms

be985ca

nidamalikk added 3 commits July 2, 2026 15:24

Added some eff histograms

d29aa94

Added some eff histograms

2188285

Merge branch 'master' into master

d35cf80

Added some eff histograms

14475d4

Added some eff histograms

10318ba

Added some eff histograms

bbe2239

Added some eff histograms

1567c10

SwatiSaha-1997 approved these changes Jul 2, 2026

View reviewed changes

SwatiSaha-1997 merged commit b9d05e0 into AliceO2Group:master Jul 2, 2026
14 of 15 checks passed

Uh oh!

Conversation

nidamalikk commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 2, 2026

Uh oh!

alibuild commented Jul 2, 2026

Uh oh!

alibuild commented Jul 2, 2026

Uh oh!

SwatiSaha-1997 commented Jul 2, 2026

Uh oh!

nidamalikk commented Jul 2, 2026

Uh oh!

alibuild commented Jul 2, 2026

Uh oh!

SwatiSaha-1997 commented Jul 2, 2026

Uh oh!

vkucera commented Jul 2, 2026

Uh oh!

SwatiSaha-1997 commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Jul 2, 2026

Uh oh!

SwatiSaha-1997 commented Jul 2, 2026

Uh oh!

Uh oh!

vkucera commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 2, 2026 •

edited

Loading

SwatiSaha-1997 commented Jul 2, 2026 •

edited

Loading