[Tools] MlResponse: bugfix assure equality of number of checked features to that in the .onnx file#16722
Merged
Merged
Conversation
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
fmazzasc
approved these changes
Jun 18, 2026
mcoquet642
pushed a commit
to AliceMCH/O2Physics
that referenced
this pull request
Jun 30, 2026
…res to that in the .onnx file (AliceO2Group#16722)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check introduced by PR #16424 did not take into account the case when input features are not configured via json file, but are fixed (as in PWGHF/TableProducer/trackIndexSkimCreator.cxx), and thus
mCachedIndices.size() == 0.This PR fixes this error by moving the check from
init()togetModelOutput()and checkinggetNumInputNodes()against the size of the input features vector.Tagging @fgrosa