Repository navigation
Conversation
sawenzel
force-pushed
the
detectorlist-active-modules
branch
from
November 16, 2026 18:00
0bdcfa1 to
e7838d0
Compare
This makes the MC workflow take only detectors that the o2-sim detector list builds. - The detector list is read like o2-sim --detectorList does, from O2_ROOT or a name:path custom file; an unreadable list is an error, as in o2-sim. - isActive() is false for modules the list does not build, and they are dropped from --readoutDetectors with a message, since o2-sim rejects them. - The ITS/IT3 choice in the task setup and the QED module list follow the list instead of its name. - An empty set of active detectors, also after removing ZDC, is now an error instead of enabling all. https://its.cern.ch/jira/browse/O2-7267
sawenzel
force-pushed
the
detectorlist-active-modules
branch
from
November 16, 2026 18:44
e7838d0 to
5a7e465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the MC workflow take only detectors that the o2-sim detector list (
--detectorList) builds.Until now the active detectors came only from
--readoutDetsor the anchored run, so a detector missing from the list stayed active. With TRD leavingALICE2.1, anALICE2.1workflow would still schedule the TRD digitisation and reconstruction, and pass TRD to--readoutDetectors, which o2-sim rejects for a module it does not build.$O2_ROOT/share/config/o2simdefaultdetectorlist.jsonor aname:pathcustom file; an unreadable list is an error, as in o2-sim.isActive()is false for modules the list does not build, and they are dropped from--readoutDetectorswith a message.Detector names are taken literally: an explicit
ITSwithALICE2.1is dropped as not built. IT3 still counts as ITS throughisActive("ITS"), as before.Checked with
daily-20261116and the list without TRD, at a fixed seed:ALICE2(pp, Pb-Pb with QED, and--readoutDets ITS,TPC,ZDC): workflow identical to master;ALICE2.1:trddigi,trdrecoandtrdreco2dropped;--readoutDets ZDCwithout--with-ZDC, an unknown list name and a malformed list stop with an error;This should go in before the AliceO2 change that removes TRD from
ALICE2.1(AliceO2Group/AliceO2#16139).https://its.cern.ch/jira/browse/O2-7267