ITS: GPU: fix perPrimaryVertexProcessing#15522
Merged
Merged
Conversation
With using the GPU stack allocator, we cannot in the perPrimaryVertexProcessing push to the stack in initialiseTimeFrame since it is only called once while computeLayerTracklets to findRoads is called once per vertex. In findRoads we tried to clear a tag from a previous iteration while the stack is empty leading to a fatal. This fixes that and avoid creating the tracklet LUT buffer on each pass.
f3sch
requested review from
fprino,
mconcas,
mcoquet642 and
shahor02
as code owners
Collaborator
Author
|
@fprino please merge |
fprino
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With using the GPU stack allocator, we cannot in the perPrimaryVertexProcessing-mode push to the stack in initialiseTimeFrame since it is only called once while computeLayerTracklets to findRoads is called once per vertex. In findRoads we tried to clear a tag from a previous iteration while the stack is empty leading to a fatal. This fixes that and avoid creating the tracklet LUT buffer on each pass.