Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHUNK_SIZEWhy this is meaningful
Both pasted notes and uploaded documents flow through
_chunk_textbefore their content is embedded and stored. Previously, a short fact immediately before a sentence longer than 800 characters was silently discarded, so retrieval and generated replies could never use it. The fix prevents that data loss while retaining the existing chunk order, overlap behavior where capacity permits, retrieval contract, and public interfaces.Validation
.venv/bin/python -m pytest— 282 passed.venv/bin/python -m pytest tests/unit/services/test_kb_service.py— 19 passed.venv/bin/python -m pytest— 283 passed.venv/bin/python -m compileall -q . -x '/.venv/'— passedgit diff --check— passed[25, 800, 176], retains the prefix, and keeps every chunk at or below 800 charactersRisk and rollback
Risk is low and localized to knowledge-base chunk construction. Inputs without the mixed short/oversized pattern keep their prior behavior; overlap is reduced only when the next piece would otherwise exceed the configured chunk size. Roll back by reverting the single feature commit.
Prepared with automated assistance by EQ for AliZakaee.