Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is meaningful
Before this change, an approval card remained sendable after the customer changed the underlying message. The owner could therefore approve and deliver a response generated for stale text. The edit handler now reuses the same pending-only atomic invalidation path as the deletion handler, while leaving owner edits and already-handled deliveries untouched.
Validation
.venv/bin/python -m pytest— 279 passed.venv/bin/python -m pytest --cov=. --cov-report=term-missing --cov-report=xml --cov-report=html --junitxml=junit.xml— 279 passed, 60% total coverage.venv/bin/python -m pytest tests/unit/handlers/test_business_updates.py -q— 21 passed.venv/bin/python -m pytest --cov=. --cov-report=term-missing --cov-report=xml --cov-report=html --junitxml=junit.xml— 282 passed, 61% total coverage.venv/bin/python -m compileall -q handlers tests— passedgit diff --check— passedRisk and rollback
Risk is low: the change only transitions matching
pendingapprovals to the existinginvalidatedstate. It does not change the database schema, public API, configuration, dependencies, authentication, permissions, or delivery logic. A narrow concurrency case where an edit arrives before approval creation remains outside this patch. Roll back by reverting commit05cd471.Prepared with automated assistance by EQ for AliZakaee.