Repository navigation
fix(forge): alinear la cara de escritorio y el diálogo nativo - #178
Open
Alexendros wants to merge 1 commit into
Open
Alexendros wants to merge 1 commit into
Alexendros wants to merge 1 commit into
Conversation
La ventana abre a 1440×900 y el inspector sigue lateral hasta 960px. El guardado usa el reactor de Tauri para no abortar, y el estado de disco se lee en español. La sonda de portal no cierra P6. FR-EXPORT-001 FR-DRAFT-001 NFR-SEC-001 NFR-ACC-001 NFR-OFF-001 NFR-DET-001
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: b5acdbe1-9150-4807-8a80-072b406105dd) |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivo
Dejar la cara Forge de escritorio alineada con la ventana de producción y con un diálogo de guardado que no aborta, sin publicar ni mover
v0.1.0.IDs trazados
FR-EXPORT-001, FR-DRAFT-001, NFR-SEC-001, NFR-ACC-001, NFR-OFF-001, NFR-DET-001. Validadores F5, F6, P6. Amenaza THR-IMP-001: el diálogo no ejecuta contenido ni abre shell.
Cambios
labelStorageUiStateen el paso, el inspector y la revisión.save_export_bytesabreAsyncFileDialogdentro del reactor de Tauri.ARCHMAKER_SAVE_DIRsolo elige la carpeta inicial de la sonda.tools/run_p6_portal_e2e.pypara cancelar, guardar, rechazar/aceptar sobrescritura y destino sin permisos.rustfmtdel hook pasa--edition 2021, la edición del crate.Fuera de alcance
Publicar, firmar, tagear o mover
v0.1.0. ISO, runner, root, discos y shell. H07 Multilib. Aceptar el alcance declarativo. DPI 125/150/200 y P95 desktop no se midieron: siguenpending/blocked.Contratos/migraciones
Sin contrato nuevo. Capabilities intactas: solo
allow-save-export-bytes.Seguridad/privilegios
Deny-by-default. Sin
dialog:*,fs:*ni shell. El gancho de directorio no escribe solo.Accesibilidad/visual
Axe en claro, oscuro, alto contraste, teclado y viewports 360/768/1440. Baselines regenerados porque a 1280px la cara mantiene tres columnas (antes el inspector bajaba en el límite de 1280px).
Pruebas y evidencias
cargo test -p archmaker --lib --locked save_— 12 passed.check_product_naming.py,check_negative_capabilities.py,check_desktop_offline_gate.py— OK. El gate sigue blocked (sourceShade la evidencia versionada ≠ este commit).target/debug/archmaker, no sobre un AppImage del tip:gui-cancelygui-dialog-realpassed;gui-overwriteygui-destination-nopermsfailed. No cierra P6 ni F9.Documentación
Notas en F5, P6 y el cierre desktop. Sin
technicalResultde aprobación y sinRC_SHA_FUNCIONAL.Checklist DoD
passeden el AppImage del tipNote
Medium Risk
Changes desktop export dialog integration (async portal path) and responsive breakpoints that affect layout at common widths; P6 gate remains blocked pending full portal E2E on the tip AppImage.
Overview
Aligns Forge desktop with a 1440×900 default window (min 960×640) and retunes responsive CSS so the inspector stays lateral until 960px and the rail yields to the stepper below 720px, with Playwright coverage for column counts and Spanish disk-state copy via
labelStorageUiStatein the disk step and review.Native export no longer uses synchronous
rfd::FileDialog;save_export_bytesrunsAsyncFileDialogon Tauri’s async runtime (avoids portal/Tokio panics), honorsARCHMAKER_SAVE_DIRonly as the dialog’s initial folder, and adds unit coverage for the reactor bridge. A newtools/run_p6_portal_e2e.pyAT-SPI probe exercises cancel/save/overwrite/no-perms; closure docs record debug results (cancel/save passed; overwrite and no-perms still failing).rustfmt --edition 2021is wired in lint-staged.Reviewed by Cursor Bugbot for commit afe9c99. Configure here.