Repository navigation
fix(web): CSP /forge-face.css y gate de arranque (H17) - #171
Merged
Merged
Conversation
Vite inyectaba <style> bloqueado por style-src 'self'; sin layout. Plugin que emite CSS externo, gate de arranque !ready/bootError y tests responsive contra el stylesheet (H17).
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d02497a6-c473-4b07-ad8c-3d48472cc7a1) |
2 of 3 tasks
1 of 2 tasks
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
styles.csscomo/forge-face.css(CSPstyle-src 'self', sin<style>de Vite).!ready/bootErroren App; rail/stepper deshabilitados hasta draft.Test plan
pnpm --filter @archmaker/web checkplaywright test responsive-layout.playwright.test.ts mock-flow.playwright.test.tsvite buildemitedist/forge-face.cssy link enindex.htmlNote
Medium Risk
Touches CSP asset pipeline and app boot/navigation gates; mis-served CSS or boot logic could leave the UI unstyled or stuck, but scope is web-only with no auth or data-path changes.
Overview
Fixes H17: strict CSP
style-src 'self'no longer breaks styling because Vite’s injected<style>tags are replaced by a single same-origin stylesheet/forge-face.css. A new Vite plugin concatenates design tokens andstyles.css, serves it in dev, injects the<link>into HTML, and emits the asset on build; the manual token link andimport "./styles.css"from the app entry are removed.Boot gating hardens the shell when catalog/draft setup fails:
bootErrorshows an alert UI, step content only renders afterready, rail/stepper buttons are disabled, andgoToStepis blocked until boot succeeds. Playwright responsive tests now assert layout rules from/forge-face.cssand expect only the viewport-visible nav control. The forge-integrity findings doc records H17 as fixed.Reviewed by Cursor Bugbot for commit d408cf6. Configure here.