Review: preserve CUE track metadata at launch - #25
Open
Alexbeav wants to merge 1 commit into
Open
Conversation
Owner
Author
|
@cubic-dev-ai review this PR |
@Alexbeav I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a same-stem CUE currently replaces it with the BIN before mounting, so the runtime loses the CUE track layout. Use the existing
resolve_disc_path(path).mountresult at the launch adapter. Raw-only images, CHD and the resolver's unusable-CUE fallback retain their existing behavior.The source-owned regression extracts the actual adapter and compiles it with the production resolver and parser. The unchanged adapter loses track metadata in four of eight synthetic cases; the corrected adapter passes all eight, including 12-track mixed media and eight-track audio-only media through both CUE and BIN entry points. It checks track numbers, types and starts.
Run
python runtime/tests/test_launch_disc_path.py --helpfor the configured-compiler entry point. CTest registers the regression for GNU/Clang C++ builds.Validation and limits
8d56cf659fd84367c3f778e17851674ac7896371; review head:7c11d57ea12812aa01587dcb5c313093ed1123d5.49f53d0ef9bbf63a3a03f064534901434bf93bf601d8b4de811768ea84eac630. This is bounded startup and normal shutdown, not gameplay completion or listening acceptance. Audio used SDL dummy output. No native Linux/macOS game route is claimed.dirty_text_continuation_guards,aot_overlay_discovery,release_zip) and three disabled tests. This branch does not change that recompiler source. Those baseline failures are not reported as passes.Scope and fork review
This review targets immutable
review-base/mstan-8d56cf659fd8. It contains 1 commit and 4 changed files. Do not merge it into the fork default branch; it is the review record before upstream submission.docs/LAUNCH_DISC_PATH.md: behavior and verification documentation.runtime/CMakeLists.txt: source-owned regression and test registration.runtime/src/main.cpp: bounded correction.runtime/tests/test_launch_disc_path.py: source-owned regression and test registration.Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.
Summary by cubic
Fixes the launch adapter so selecting a same-stem CUE keeps its track layout instead of swapping it for the BIN before mounting. The adapter now returns
resolve_disc_path(path).mount; raw-only images, CHD, and the unusable-CUE fallback behave as before.Bug Fixes
docs/LAUNCH_DISC_PATH.md.Written for commit 7c11d57. Summary will update on new commits.