Open
Conversation
All items with Attack Damage & Attack Speed attributes been updated to use the correct base id, so that they are displayed properly in-game.
Added two missing tags to make Brainiacs be considered Undead again, and to make Raygun damage not apply knockback.
Radiation Damage no longer applies knockback now.
Added the base two tags (tagging all enchantments) so that they can now appear in-game in the Enchantment Table.
This is the main tag to allow the enchantments appear when enchanting their respective items.
This is the base enchantment tag which automatically applies a lot of other tags to the enchantments, making them appear everywhere (such as on random enchanted book loot) when by default, the enchantments should only be available via using the Enchanting Table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahoy! This is simply just me offering a tiny bit of help to bugfix a few things. Mostly that the Items with Attack Attributes properly using the vanilla ids for damage & speed (this allows those items to have a proper display in-game UI where it shows the proper green numbers for damage/speed instead of odd blue numbers).
I also added the missing tag for the raygun damage type so that it doesn't apply knockback and the missing tag for brainiacs to make them undead.
Note: I added notes in every item in relation I've edited to explain that there is a new option to replace attributes on an item via Item.Properties where it is .attributes(). I didn't apply this change myself as I wasn't sure if Alex prefers the override method that is currently being used or would want to swap to the newer method.