feat: hide MCP list tools#60
Open
csush wants to merge 3 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR updates the MCP integration so that mcp_list_tools is used strictly for internal orchestration (tool discovery) and is no longer emitted as streamed events or included in the final response.output. The demo UI is also adjusted to stop rendering MCP tool-list output.
Changes:
- Replace streaming
listMcpToolsStreamwith an internallistMcpToolsfunction that returns tool metadata without emitting response output/events. - Update server-side and integration tests to assert
mcp_list_toolsis not present in response output. - Remove demo-side rendering/types for MCP tool-list output items.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/responses.test.js | Updates assertions to ensure mcp_list_tools never appears in final outputs. |
| src/routes/responses/mcpStream.ts | Converts tool listing from a streamed output item to an internal-only async function. |
| src/routes/responses/mcpStream.test.ts | Updates tests for the new internal listMcpTools behavior. |
| src/routes/responses/innerStream.ts | Switches orchestration to call listMcpTools without emitting output items/events. |
| src/routes/responses/innerStream.test.ts | Updates MCP stream mocking to the new function name. |
| src/routes/responses/closeOutputItem.ts | Updates comment to reflect list-tools output is internal-only. |
| demo/lib/assistant.ts | Removes demo types/handling for mcp_list_tools output items. |
| demo/components/chat.tsx | Stops rendering MCP tool-list UI in the chat component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -61,7 +54,7 @@ export interface McpApprovalRequestItem { | |||
| arguments?: string; | |||
| } | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
@copilot Remove it from the demo, importing *.ts is a bad practice anyway.
Comment on lines
74
to
85
| (connectMcpServer as ReturnType<typeof vi.fn>).mockResolvedValue(mockClient); | ||
|
|
||
| const responseObject = createMockResponseObject(); | ||
| const events = await collectEvents(listMcpToolsStream(mcpTool, responseObject, traceContext, log)); | ||
| const types = events.map((e) => e.type); | ||
| const result = await listMcpTools(mcpTool, traceContext, log); | ||
|
|
||
| expect(types).toEqual([ | ||
| "response.output_item.added", | ||
| "response.mcp_list_tools.in_progress", | ||
| "response.mcp_list_tools.completed", | ||
| "response.output_item.done", | ||
| ]); | ||
| expect(types.filter((t) => t === "response.output_item.done")).toHaveLength(1); | ||
| expect(result).toMatchObject({ | ||
| type: "mcp_list_tools", | ||
| server_label: "test-server", | ||
| tools: [{ name: "search", input_schema: { type: "object" }, description: "Search tool" }], | ||
| }); | ||
| expect(responseObject.output).toEqual([]); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.