[RyeMutt]

Description

Tapple's tenth round of Script Studio QA covers six reports: two in the converter's keys as uuids, the explorer losing linked prims, the link notice's length and buttons, and SLua event hovers.

One commit partly undoes nopjmp's 7977a06902. That commit held a key declared with nothing as text, since LSL's key k; holds "". Tapple asked to have key k; mean key k = NULL_KEY; again where keys are uuids, as it did before, and that was decided on 2026-10-27. The difference from LSL is noted in the script. key k = ""; still stays text, for round seven's link-message case.

llList2Key's key made text holds its item's text, not NULL_KEY's

• With keys as uuids, a key held as text that was given llList2Key's item took tostring(llcompat.List2Key(...)). SLua's List2Key answers NULL_KEY for "" and for any text that is no UUID. Tapple's av = llList2Key(["", ...], 0); if (av != "") printed ["00000000-..."] where LSL printed [].
• Wherever llList2Key's key is made text (Writer::coerced), its item is now read as List2String reads it: av = newAssignments[1] or "". Keys as text already worked this way (round eight). A key held as a uuid keeps llcompat.List2Key.
• The same applies to string msg = llList2Key(l, 0) with keys as uuids, which gave NULL_KEY's text for text that is no UUID. SluaList2KeyText is reworded to fit, in the converter and in strings.xml.

A key declared with nothing is NULL_KEY again where keys are uuids

• key av; is local av: uuid = NULL_KEY, compared with "" as uuid(""), and given llList2Key as List2Key. Tapple's script now comes out exactly as they asked.
• A note over the first such declaration says it (SluaKeyDeclared, once a script, like the other key notes). The key equals NULL_KEY and reads as NULL_KEY's text, where LSL's did neither.
• key av = ""; is still text. With keys as text, nothing changes.
• The test expectations that 7977a06902 changed for this are back to what they were (gOwner, gSitter, gSender), and its "holds no text" test is replaced.

A file's tab keeps the prims of the scripts it masters in the explorer

• The explorer lists objects that are pinned, selected in world, or have a script open. A linked script's tab gives way to its file's tab, which names no prim. So a prim whose open scripts were all linked dropped out once the edit window closed and deselected it.
• A file's tab now counts as open for every script it masters, unless the link is orphaned. Making or removing a link relists the explorer.

Hover on an SLua event's handler says its parameters again

• function LLEvents.run_time_permissions() hovered as nothing. The old solver types only LLEvents in a function statement's name, and the editor's fallback asked the definitions for the dotted name, where events are kept bare. The old script editor showed the arguments.
• A field with no type of its own now takes the type the table or extern type it is on gives it. A field holding a function or nil hovers as the function: function LLEvents.run_time_permissions(perm: number), under either solver.

Compare with the world's script says why it could not read it

• The link notice's Compare read the script in-world and, where the read failed, returned without a word. Tapple saw the button only close the notice.
• The failure is now reported on the file's tab, with the reason (MasterWorldNotRead). Nothing else on that path drops the comparison, and the masters test compares as it should. The cause in Tapple's viewer was not reproduced, so the hand check below matters.

Script Studio's notice wraps its words onto up to three lines

• A link's notice was about three times what fitted on the bar's one line. It was cut off with an ellipsis, and the full text was only in the tooltip.
• The words now wrap in the space the buttons leave, and the bar grows to fit them, up to three lines. It is fitted again when the window is resized, and the tooltip still holds all of it (ALScriptNoticeBar::fitWords).
• Shorter link words: "[NAME] is linked to [FILE]: each save of the file sends it. They differ now: the next save sends the file, keeping what [NAME] held in History."

A file's link offers Update File: the script's world text into the file

• Tapple asked for a way to sync the other way from Send File.
• Update File (master_take_world) reads what the script holds in-world, out of its envelope, and puts it in the file's tab as one step to undo. The file on disk is written only when the tab is saved, and that save then sends what the script already holds.
• It is offered wherever Send File and Compare are, on the file's tab. Where the tab already holds the world's text, it says so and changes nothing.

Related Issues

None: Tapple's QA notes of 2026-10-22 to 2026-10-25, forwarded.

Issue Link: none

---

Checklist

• I have provided a clear title and detailed description for this pull request.
• If useful, I have included media such as screenshots and video to show off my changes.
• I have tested the changes locally and verified they work as intended. (Unit tests only; see Hand checks.)
• All new and existing tests pass.
• Code follows the project's style guidelines.
• Documentation has been updated if needed.
• Any dependent changes have been merged and published in downstream modules
• I have reviewed the contributing guidelines.

---

Additional Notes

Testing

• On the tip, alscript passes 703/703 test cases and newview passes 747 of 748 (one skipped). The changed viewer files build.
• New tests:
  • allsltoslua: Tapple's script with key av;, = "" and = NULL_KEY, and a key declared with nothing, noted and with keys as text.
  • alluauservice: an event's handler hovered while being written and while being read, under both solvers.
  • alscriptstudiomasters: Compare through a refused read and a successful one, and Update File put in the tab, undone, and taken again when already the same.
  • alscriptstudioorphans: the real bar from the skin, one line, two, and past three.

Hand checks

• Link every open script of a prim to files, then close the edit window: the prim stays in the explorer. Close the file's tab: it goes.
• Link a script to a file that differs: the notice wraps onto two or three lines, in a narrow window and a wide one.
• On that notice, Compare shows the file beside the script in-world. If it still shows nothing, see what the status bar says.
• Update File puts the in-world text in the file's tab, unsaved, with undo taking it back. Saving writes the file, and the send that follows should find the script already holds it.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 41502a6b-b468-4d0a-bbe2-247ac12731a0

Commits

Reviewing files that changed from the base of the PR and between da5a827 and 99de048.

Files selected for processing: 16

• indra/alscript/lsl/allsltoslua.cpp
• indra/alscript/luau/alluauservice.cpp
• indra/alscript/tests/allsltoslua_test.cpp
• indra/alscript/tests/alluauservice_test.cpp
• indra/newview/alfloaterscriptstudio.cpp
• indra/newview/alscriptexplorerpane.cpp
• indra/newview/alscriptnoticebar.cpp
• indra/newview/alscriptnoticebar.h
• indra/newview/alscriptoutputpane.cpp
• indra/newview/alscriptstudiomasters.cpp
• indra/newview/alscriptstudiomasters.h
• indra/newview/alscriptstudioorphans.cpp
• indra/newview/skins/default/xui/en/floater_script_studio.xml
• indra/newview/skins/default/xui/en/strings.xml
• indra/newview/tests/alscriptstudiomasters_test.cpp
• indra/newview/tests/alscriptstudioorphans_test.cpp

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}