Repository navigation
Stop running vcpkg's app-local step on the tools a tests build makes - #590
Merged
Merged
Conversation
Whitespace and one wrapped call only, so the change that follows reads on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows ARM Tests build stopped at the link of xui_translate_repair (#581, #584) and of llui_libtest (#578) with "The process cannot access the file because it is being used by another process." The half of the command that failed is the POST_BUILD "vcpkg z-applocal" that vcpkg's toolchain hangs on every executable declared while VCPKG_APPLOCAL_DEPS is on, and the three llui utilities, ready at the same moment, link together. The directory they share, sharedlibs/<config>, is not what fails. They import no port's DLL on Windows, where the spell checker is the system's, so z-applocal copies nothing. Eighty concurrent z-applocal runs, each into a directory of its own, fail the same way 3 times in 640, and eighty concurrent "vcpkg version" runs 6 times in 640: a start of vcpkg.exe beside another fails now and then, as d5095f9 found for the test binaries. So these are declared with the step off, as al_add_test_binary declares a test: the three utilities, http_texture_load (the other executable in sharedlibs/<config>) and llimage_libtest. Each exists only in a tests build and runs from the build tree; xui_overlay_check's ctest entry still runs with AL_TEST_ENVIRONMENT's PATH. Serializing them instead would leave them racing every other launch of vcpkg.exe in the build, and a Ninja job pool does nothing under MSBuild. With AL_USE_WINSPELLCHECK turned off, llui links Hunspell's DLL, which llui_libtest and xui_translate_repair no longer copy into sharedlibs/<config>; the llui tests, whose PATH names that directory, would then need vcpkg's bin directory on it. No CI row builds that way. Proof: a tests-on vs2026-os configure leaves z-applocal on five projects, alchemy-bin, dullahan_host, media_plugin_cef, media_plugin_libvlc and template_verifier, and on none of these; the three utilities build in Release and ctest -R xui_overlay_check passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
build (windows-11-vs2026-arm, release, arm64, Tests)link failure, "The process cannot access the file because it is being used by another process". It hitxui_translate_repairon #581 and #584 andllui_libteston #578.Cause
The step that fails is vcpkg's post-link
vcpkg z-applocal. vcpkg's toolchain adds it to every executable declared whileVCPKG_APPLOCAL_DEPSis on. The three llui utilities are ready at the same moment, so they link together.Their shared directory,
sharedlibs/<config>, is not the cause. On Windows the spell checker is the system's, so the utilities import no port's DLL andz-applocalcopies nothing. Launching 80 copies ofvcpkg.exeat once, 8 rounds:z-applocal, each into its own directoryz-applocal, all into one directoryvcpkg versionStarting
vcpkg.exewhile another one starts sometimes fails. d5095f9 found the same thing for the test binaries.Commits
Format llui/utils and llcorehttp's CMake files with gersemi. Formatting only, so the fix diff stays small.
Stop running vcpkg's app-local step on the tools a tests build makes. These now set
VCPKG_APPLOCAL_DEPS OFF, asal_add_test_binarydoes for tests:http_texture_load, the other executable insharedlibs/<config>;llimage_libtest.Each exists only in a tests build and runs from the build tree.
xui_overlay_check's ctest entry still runs withAL_TEST_ENVIRONMENT's PATH. Serializing the steps instead would leave them racing every othervcpkg.exelaunch in the build, and a Ninja job pool does nothing under MSBuild.Not covered
z-applocalon five projects:alchemy-bin,dullahan_host,media_plugin_cef,media_plugin_libvlcandtemplate_verifier. They can still race each other.AL_USE_WINSPELLCHECK=OFF, llui links Hunspell's DLL.llui_libtestandxui_translate_repairno longer copy it intosharedlibs/<config>, so the llui tests would need vcpkg's bin directory on their PATH. No CI row builds that way.Testing
On a fresh Windows
vs2026-osconfigure with-DAL_BUILD_TESTS=ON:z-applocalstep;vcpkg.exelaunch in the log;ctest -R xui_overlay_checkpasses;llui_libtestandxui_translate_repairstart.Not yet run on ARM64. This PR's CI run is the first check there.
🤖 Generated with Claude Code