Repository navigation
Support F13-F24 keys - #580
Merged
RyeMutt merged 12 commits intoOct 26, 2026
Merged
Conversation
Keys remapped to F13-F24, common for macro keys, could not be bound because the viewer knew only F1-F12. The codes sit contiguously after F12 in unused space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDL also covers macOS, where the system exposes up to F20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They do not auto-repeat and can be remap targets, as F1-F12 are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preferences looked them up and logged them as missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Martin-Pitt
marked this pull request as ready for review
October 26, 2026 14:51
Contributor
Author
|
Simple PR all around, can remove injection comments if you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds F13–F24 as keys the viewer knows, so they can be bound like F1–F12 (for example on macro pads and keyboards that send them).
KEY_F13–KEY_F24key codes and their names inLLKeyboardVK_F13–VK_F24on Windows andSDLK_F13–SDLK_F24on SDLllviewerinput.cpp's range checksstrings.xml🤖 Generated with Claude Code