Repository navigation
Conversation
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
I think you may as well add luascans and omegascans to this pr as well to show that the template works. or if you wanted to keep things separate, you could have stacked prs.
…ic_manga for listings, use builtin parse_date
|
Resolves #609 |
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
is it possible to support tag search on tap? since genres are collected as a dynamic filter, it's not automatically supported, so you would need to either create a script to statically generate a filters.json, or add supportsTagSearch in the source.json config and handle the "genre" filter in search with only the name of the tag.
| .description | ||
| .and_then(|d| Html::parse_fragment(d).ok()) | ||
| .and_then(|html| html.select_first("body")?.text_with_newlines()) | ||
| .map(|d| d.trim().into()), |
There was a problem hiding this comment.
it's possible for this to be an empty string, in which case it should be returned as None instead.
| .map(|d| d.trim().into()), | |
| .map(|d| d.trim().into()) | |
| .filter(|d| !d.is_empty()), |
| qs.push(&id, sort); | ||
| qs.push("order", Some(if ascending { "asc" } else { "desc" })); | ||
| } | ||
| FilterValue::MultiSelect { id, included, .. } => { |
There was a problem hiding this comment.
I think you don't set can_exclude to false on the genres filter despite not supporting excluded values.
This branch has not been deployed
2 participants
ported from https://github.com/keiyoushi/extensions-source/tree/main/lib-multisrc/heancms/src/eu/kanade/tachiyomi/multisrc/heancms
tested with a luascans test source and it seems to work fine