Skip to content

test: add proposal cancellation and waitlist edge case tests#690

Merged
Yunusabdul38 merged 1 commit into
Agora-Events:mainfrom
ayinde38:issue-686-687
May 26, 2026
Merged

test: add proposal cancellation and waitlist edge case tests#690
Yunusabdul38 merged 1 commit into
Agora-Events:mainfrom
ayinde38:issue-686-687

Conversation

@ayinde38
Copy link
Copy Markdown
Contributor

  • Add four new test cases for proposal cancellation scenarios (issue C-58):
  • test_cancel_proposal_by_proposer: verify proposer can cancel and second cancel returns ProposalAlreadyCancelled
  • test_cancel_already_executed_proposal: ensure cancelling executed proposal returns ProposalAlreadyExecuted
  • test_cancel_proposal_by_non_proposer: confirm non-proposer cancellation returns Unauthorized
  • test_vote_on_cancelled_proposal: validate voting on cancelled proposal returns ProposalAlreadyCancelled
  • Add helper function register_event_with_supply for waitlist tests with finite ticket supply
  • Import TicketTier type in test_waitlist module for event registration with tier configuration
  • Expand waitlist test coverage with edge cases for supply constraints and tier limits

Closes: #686
Closes: #687

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

@ayinde38 is attempting to deploy a commit to the oseh-svg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 26, 2026

@ayinde38 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Copy link
Copy Markdown
Contributor

@Yunusabdul38 Yunusabdul38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution

@Yunusabdul38 Yunusabdul38 merged commit e91e7ed into Agora-Events:main May 26, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add event_registry unit test for multisig proposal cancellation Add event_registry unit test for waitlist join and full event guard

2 participants