refactor(sandbox): unify Claude and Codex into single multi-stage Dockerfile#151
Open
visahak wants to merge 4 commits intoAgentToolkit:mainfrom
Open
refactor(sandbox): unify Claude and Codex into single multi-stage Dockerfile#151visahak wants to merge 4 commits intoAgentToolkit:mainfrom
visahak wants to merge 4 commits intoAgentToolkit:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Codex “Evolve Lite” integration and docs; converts the sandbox into multi-stage Docker builds with separate Claude and Codex stages; renames just targets and adds Codex-specific tasks; introduces Codex bootstrap scripts and entrypoint; updates the learn skill to prioritize error-driven entity extraction. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Codex
participant Hook as UserPromptSubmit Hook
participant FS as .evolve/entities (filesystem)
User->>Codex: Send prompt (session)
Codex->>Hook: UserPromptSubmit triggers (on submit)
Hook->>FS: read relevant entities by trigger/type
Hook-->>Codex: inject recalled entities into prompt context
Codex->>FS: (learn flow) extract entities -> write Markdown with YAML frontmatter
FS-->>Codex: persisted entities available for future recall
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vinodmut
reviewed
Apr 6, 2026
Contributor
vinodmut
left a comment
vinodmut
left a comment
There was a problem hiding this comment.
Rename this file to evolve-lite-claude.md?
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@justfile`:
- Around line 20-27: The sandbox-build recipe can hide a failed docker build
because the script doesn't stop on error; update the sandbox-build target to
fail fast by enabling shell errexit (e.g., run "set -e" / "set -o errexit") at
the top of the recipe or append explicit failure checks to each docker build
command (e.g., check the exit status or add "|| exit 1") so that a failing build
for the claude image aborts the rest and returns a non-zero status; modify the
sandbox-build target and the docker build invocations (referenced as
sandbox-build target, the docker build --target claude and docker build --target
codex commands, and the "{{target}}" conditional logic) accordingly.
In `@sandbox/codex/bootstrap_codex_config.py`:
- Around line 21-31: The current ensure_top_level_setting function only skips
insertion if a key prefix exists, leaving wrong values in place; update
ensure_top_level_setting to detect an existing key (using prefix = f"{key} ="),
parse or strip the existing value and if it differs from the desired value
replace that line in-place (e.g., lines[i] = f'{key} = "{value}"\n') instead of
returning False, otherwise return False only when the value already matches;
apply the same approach to the analogous helper referenced at lines 53-69 so
both will update incorrect existing settings (use the function name
ensure_top_level_setting to find the current logic and mirror the replacement
behavior).
In `@sandbox/codex/entrypoint.sh`:
- Around line 4-8: The fallback order in entrypoint.sh makes /codex-home
unreachable because codex_home="${CODEX_HOME:-${HOME:-/codex-home}}" prefers
HOME from the image; change the fallback logic so CODEX_HOME defaults to
/codex-home when CODEX_HOME is unset (e.g., set codex_home using CODEX_HOME
first, then default to /codex-home if neither CODEX_HOME nor HOME are set),
ensure subsequent exports export HOME and CODEX_HOME consistently, and update
references to the codex_home variable in this script to use the new assignment
(symbols: codex_home, CODEX_HOME, HOME, entrypoint.sh).
In `@sandbox/README.md`:
- Line 80: Update the README sentence that currently says "just codex-run starts
in /workspace" to explicitly state the demo thread starts in
"/workspace/demo/workspace" so the documented demo paths match the actual
session location; also update the related paragraph(s) around lines referenced
(the block mentioning demo data under demo/workspace and the duplicate section
at 104-109) and make the same correction in
docs/integrations/evolve-lite-codex.md so both files consistently reference
"/workspace/demo/workspace" as the Codex demo home.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 49679a0d-e393-4684-9850-59906c6ff518
📒 Files selected for processing (8)
docs/integrations/evolve-lite-codex.mddocs/integrations/evolve-lite.mdjustfilesandbox/Dockerfilesandbox/README.mdsandbox/codex/bootstrap_codex_config.pysandbox/codex/entrypoint.shsandbox/sample.env
…kerfile - Replace separate sandbox/Dockerfile and sandbox/codex/Dockerfile with a single multi-stage Dockerfile (--target claude / --target codex) - Rename sandbox-* justfile targets to claude-* for agent clarity - Add sandbox-build/sandbox-clean with optional target param (claude/codex/all) - Add codex-run and codex-test justfile targets - Add sandbox/codex/entrypoint.sh and bootstrap_codex_config.py - Merge sandbox/codex/README.md into unified sandbox/README.md - Update docs/integrations/evolve-lite.md target references - Add docs/integrations/evolve-lite-codex.md for Codex integration walkthrough - Add OPENAI_API_KEY placeholder to sandbox/sample.env Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
visahak
force-pushed
the
refactor/sandbox-unified-dockerfile
branch
from
8f472ae to
932090f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
justfile (1)
20-28:⚠️ Potential issue | 🟠 MajorValidate
targetto prevent silent no-op build/clean runs.Line 23 and Line 42 only gate known values, but unknown values currently exit 0 after doing nothing. This can hide typos in CI/local workflows.
💡 Proposed fix
sandbox-build target="all": #!/usr/bin/env sh set -e + case "{{target}}" in + all|claude|codex) ;; + *) echo "target must be one of: all, claude, codex" >&2; exit 1 ;; + esac if [ "{{target}}" = "all" ] || [ "{{target}}" = "claude" ]; then docker build --target claude -t {{claude_image}} {{sandbox_dir}} fi if [ "{{target}}" = "all" ] || [ "{{target}}" = "codex" ]; then docker build --target codex -t {{codex_image}} {{sandbox_dir}} fi sandbox-clean target="all": #!/usr/bin/env sh + case "{{target}}" in + all|claude|codex) ;; + *) echo "target must be one of: all, claude, codex" >&2; exit 1 ;; + esac if [ "{{target}}" = "all" ] || [ "{{target}}" = "claude" ]; then docker rmi {{claude_image}} || true fi if [ "{{target}}" = "all" ] || [ "{{target}}" = "codex" ]; then docker rmi {{codex_image}} || true fiAlso applies to: 40-47
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@justfile` around lines 20 - 28, The sandbox-build recipe currently treats unknown {{target}} values as a silent no-op; update the shell stub inside sandbox-build (the recipe that defines sandbox-build target="all") to validate {{target}} against the allowed set (e.g., "all", "claude", "codex") before the conditional docker build steps and if the value is not one of those, print a clear error to stderr and exit with a non-zero status (use set -e already present) so CI/local runs fail fast; apply the same validation pattern to the analogous recipe/block that handles the clean/other target (the second conditional block around the "codex" build in the file) so both build and clean paths reject unknown targets.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@platform-integrations/codex/plugins/evolve-lite/skills/learn/SKILL.md`:
- Around line 92-93: Update the broken helper script paths in the Codex skill
command snippets so they point to
platform-integrations/codex/plugins/evolve-lite/... instead of
plugins/evolve-lite/.... Specifically, locate the shell examples that invoke
save_entities.py (the echo | python3
".../plugins/evolve-lite/skills/learn/scripts/save_entities.py" lines) in
SKILL.md and replace the leading path with
platform-integrations/codex/plugins/evolve-lite to ensure the echo ... | python3
command resolves correctly; apply the same fix to all occurrences of the save
commands shown in the file.
---
Duplicate comments:
In `@justfile`:
- Around line 20-28: The sandbox-build recipe currently treats unknown
{{target}} values as a silent no-op; update the shell stub inside sandbox-build
(the recipe that defines sandbox-build target="all") to validate {{target}}
against the allowed set (e.g., "all", "claude", "codex") before the conditional
docker build steps and if the value is not one of those, print a clear error to
stderr and exit with a non-zero status (use set -e already present) so CI/local
runs fail fast; apply the same validation pattern to the analogous recipe/block
that handles the clean/other target (the second conditional block around the
"codex" build in the file) so both build and clean paths reject unknown targets.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 92e6ce68-7b5e-4abf-b3aa-6129a7044c23
📒 Files selected for processing (9)
docs/integrations/claude/evolve-lite.mddocs/integrations/evolve-lite-codex.mdjustfileplatform-integrations/codex/plugins/evolve-lite/skills/learn/SKILL.mdsandbox/Dockerfilesandbox/README.mdsandbox/codex/bootstrap_codex_config.pysandbox/codex/entrypoint.shsandbox/sample.env
✅ Files skipped from review due to trivial changes (4)
- docs/integrations/claude/evolve-lite.md
- sandbox/sample.env
- sandbox/codex/entrypoint.sh
- docs/integrations/evolve-lite-codex.md
🚧 Files skipped from review as they are similar to previous changes (3)
- sandbox/README.md
- sandbox/codex/bootstrap_codex_config.py
- sandbox/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox/Dockerfileandsandbox/codex/Dockerfilewith a single multi-stage Dockerfile (--target claude/--target codex)sandbox-*justfile targets toclaude-*for agent clarity; addcodex-runandcodex-testtargetssandbox-buildandsandbox-cleanaccept an optionaltargetparam (claude,codex, orall)sandbox/codex/entrypoint.shandbootstrap_codex_config.py(Codex-specific container setup)sandbox/codex/README.mdinto a unifiedsandbox/README.mdcovering both agentsOPENAI_API_KEYplaceholder tosandbox/sample.envdocs/integrations/evolve-lite.mdtarget referencesdocs/integrations/evolve-lite-codex.md— full Codex + Evolve Lite integration walkthroughSummary by CodeRabbit
New Features
Documentation
Chores