Repository navigation
chore: require labels on a PR, in the skill that forgets them - #82
Merged
Merged
Conversation
Thirty-odd PRs had no labels, including every one from the last two days, because this skill never asked for them. The issue skill does, which is exactly why issues were labelled and PRs were not — a mechanical step gets skipped when nothing asks for it. Both axes are mechanical, not judgement: `type:` is whatever the conventional-commit prefix already says, and `area:` follows the scope. The labels are what make `gh pr list --label area:voice` answer "what have we changed about voice"; without them that history is greppable by title only. Also says to use the project's `type:` vocabulary rather than GitHub's stock `bug` / `documentation` / `enhancement`. Those exist only because they ship with a new repo, and four PRs had picked them up — a repo carrying both has two names for one thing and neither filter returns everything.
Collaborator
Author
|
@Parv17k can you please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thirty-odd PRs had no labels, including every one from the last two days, because this skill never asked for them. The issue skill does — which is precisely why issues were labelled and PRs were not. A mechanical step gets skipped when nothing asks for it.
I have backfilled the whole history: every PR and every issue now carries labels, derived from the conventional-commit prefix the author already chose rather than from my reading of the diff. For the pre-rebuild PRs (#14–#31) I applied
type:only and deliberately notarea:— the area labels describe the current package layout, so applying them to the old codebase would be inventing a mapping rather than recording one.Four PRs had picked up GitHub's stock
bug/documentationlabels instead oftype:bug/type:docs; those are migrated, and the skill now says to use the project vocabulary. A repo carrying both has two names for one thing and neither filter returns everything.How it was verified
Documentation only, so no changelog entry — nothing shipped changes behaviour.
Deliberately left undone
bug,documentation,enhancement,duplicate,invalid,question,wontfix) along with four older capitalised ones (High Priority,Observability,Integrations,Testing). Nothing uses them now. Deleting a label is irreversible and strips it from anything still carrying it, so that is your call — say the word and I will remove them, or leave them as harmless clutter.