Skip to content

chore: require labels on a PR, in the skill that forgets them - #82

Merged
harshuljain13 merged 1 commit into
mainfrom
chore/pr-labels
Oct 18, 2026
Merged

harshuljain13 merged 1 commit into
mainfrom
chore/pr-labels

Conversation

@harshuljain13

Copy link
Copy Markdown
Collaborator

Thirty-odd PRs had no labels, including every one from the last two days, because this skill never asked for them. The issue skill does — which is precisely why issues were labelled and PRs were not. A mechanical step gets skipped when nothing asks for it.

I have backfilled the whole history: every PR and every issue now carries labels, derived from the conventional-commit prefix the author already chose rather than from my reading of the diff. For the pre-rebuild PRs (#14–#31) I applied type: only and deliberately not area: — the area labels describe the current package layout, so applying them to the old codebase would be inventing a mapping rather than recording one.

Four PRs had picked up GitHub's stock bug / documentation labels instead of type:bug / type:docs; those are migrated, and the skill now says to use the project vocabulary. A repo carrying both has two names for one thing and neither filter returns everything.

How it was verified

gh pr list --state all --limit 60 --json number,labels -q '... select((.labels|length)==0)'  → 0
gh issue list --state all --limit 40 ... → none
gh pr list ... select(any(. == "bug" or . == "documentation" or . == "enhancement")) → none

Documentation only, so no changelog entry — nothing shipped changes behaviour.

Deliberately left undone

  • The stock labels still exist (bug, documentation, enhancement, duplicate, invalid, question, wontfix) along with four older capitalised ones (High Priority, Observability, Integrations, Testing). Nothing uses them now. Deleting a label is irreversible and strips it from anything still carrying it, so that is your call — say the word and I will remove them, or leave them as harmless clutter.
  • No automation. A labeler action or a CI check that fails an unlabelled PR would make this structural rather than remembered. Worth doing if it slips again; the skill is the cheaper fix to try first.

Thirty-odd PRs had no labels, including every one from the last two days,
because this skill never asked for them. The issue skill does, which is exactly
why issues were labelled and PRs were not — a mechanical step gets skipped when
nothing asks for it.

Both axes are mechanical, not judgement: `type:` is whatever the
conventional-commit prefix already says, and `area:` follows the scope. The
labels are what make `gh pr list --label area:voice` answer "what have we
changed about voice"; without them that history is greppable by title only.

Also says to use the project's `type:` vocabulary rather than GitHub's stock
`bug` / `documentation` / `enhancement`. Those exist only because they ship with
a new repo, and four PRs had picked them up — a repo carrying both has two names
for one thing and neither filter returns everything.
@harshuljain13 harshuljain13 added the type:chore Build, CI, dependencies, release plumbing label Oct 15, 2026
@harshuljain13
harshuljain13 requested a review from Parv17k October 15, 2026 09:12
@harshuljain13 harshuljain13 self-assigned this Oct 15, 2026
@harshuljain13 harshuljain13 added this to the 0.1.0 milestone Oct 15, 2026
@harshuljain13

Copy link
Copy Markdown
Collaborator Author

@Parv17k can you please review this

@harshuljain13
harshuljain13 merged commit 2e362f0 into main Oct 18, 2026
4 checks passed
@harshuljain13
harshuljain13 deleted the chore/pr-labels branch October 18, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:chore Build, CI, dependencies, release plumbing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant