Repository navigation
chore: pin the framework at 0.0.4, and install voice from PyPI - #79
Merged
Merged
Conversation
The pins were at 0.0.2, two releases behind, so a clean install of this repo got none of the voice work it demonstrates. agentship-voice is now installed rather than noted as absent. The note said it was unpublished and had to come from a sibling checkout; it has been on PyPI since 0.0.3, and leaving that standing meant the voice demo and its tests silently SKIPPED on a clean install — `pytest.importorskip` found nothing to import and said so quietly, which reads identically to passing. The `[pipecat]` extra is what pulls Pipecat, and with it the local smart-turn model that decides whether you have finished a sentence or only paused. Verified by installing requirements-dev.txt into a clean Python 3.13 venv from PyPI: all six resolve at 0.0.4 and Pipecat 1.12 comes with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pins were at
0.0.2, two releases behind, so a clean install of this repo got none of the voice work it demonstrates. 0.0.4 went to PyPI today.agentship-voiceis now installed rather than noted as absent. The note said it was unpublished and had to come from a sibling checkout — it has been on PyPI since 0.0.3. Leaving that standing meant the voice demo and its tests silently skipped on a clean install:pytest.importorskipfound nothing to import and said so quietly, which reads exactly like passing. The[pipecat]extra pulls Pipecat, and with it the local smart-turn model.How it was verified
Installed
requirements-dev.txtinto a clean Python 3.13 venv from real PyPI, not from the sibling checkout:Deliberately left undone
pyproject.tomlstill pinsagentship-sdk[...]==0.0.1and its own version is0.0.1. That is a separate decision — whether this repo installs the SDK meta-package or the individual packages it currently lists — and changing it would alter what apip install -e .of the demo resolves. Worth a look, but not a pin bump.make docker-updoes not exercise these pins at all; what I verified is that they resolve and import.