Repository navigation
test: drain learned-quirk writers before simulating restart - #1823
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The learned-quirks restart fixture could fail after verifying a valid memo file: it forced one synchronous save but left the request's scheduled writer alive, then discarded in-memory facts. That writer could snapshot the deliberately emptied map and replace the verified file before reload, causing “a memo on disk must be believed at startup.”
Both restart fixtures now drain their owned scheduled writes before simulating restart. The mandatory-map reset also uses the existing mutex. All JSON-content, startup lookup, fake-endpoint and subsequent request-count assertions remain unchanged. This is a test-only repair; production code, request behavior, deadlines and limits do not change.
Controlled diagnostic overlays paused the actual scheduled writer before snapshot: the original ordering failed the exact assertion, while drain-before-reset passed unchanged assertions under the race detector. Required exact-base local gate and fresh provider suite passed; focused restart checks under the race detector, make build and independent review passed. Diagnostic hooks are confined to investigation overlays and are absent from this patch.
The original Full-check failure remains preserved. A separate production save-ordering defect was independently reproduced and has a separate unpublished repair; this fixture patch does not claim to resolve it. Staging remains blocked pending its disposition and an exact-candidate Full check. Maintainer review and merge are required; this PR performs no promotion.
The actual-number internal change entry for #1823 is included at final head
430d3508e4e33086e34eaabf2639ebe564f5335d. Final exact-base local gate and independent entry review passed; final-head required CI remains the readiness check.