Repository navigation
chat: a bare number-and-period reply draws instead of vanishing (#1072) - #1746
Merged
Merged
Conversation
…t-Field#1072) A model reply whose whole text was a number and a full stop (32., 1024.) parsed as a Markdown ordered list with one empty item. renderer.list drew the marker column, found no body, and popped the item as undrawn, taking the marker with it, so the reply rendered to zero rows and the deck skipped it. Draw the marker as literal text when the item body produced nothing, which is the only case a bare <number>. reaches.
4 tasks done
Contributor
Author
|
@santoshkumarradha pls review |
Member
|
Hey @7vignesh, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? https://cla-assistant.io/Agent-Field/CodeAF?pullRequest=1746 |
Contributor
Author
done |
ZeroPoint95
requested changes
Oct 8, 2026
- Rename change entry to 1746-... and set pr: 1746 (was the issue number).
- Assert the exact rendered output ('32.', '1024.', '1. one') instead of
just non-empty.
Contributor
Author
|
Thanks @ZeroPoint95. Both addressed in the latest push:
|
ZeroPoint95
approved these changes
Oct 8, 2026
Collaborator
|
Merged. Thanks for the contribution @7vignesh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A model reply whose whole text is a number and a full stop (
32.,1024.) parsed as a Markdown ordered list with one empty item.renderer.listininternal/tui2/prosepushed the marker column, rendered the empty item, and popped it as undrawn, taking the marker with it. The reply rendered to zero rows and the deck skipped it: the fold showed only the thought row though the transcript held the text (#1072).The list renderer now draws the marker as the literal text the reader sent when the item body produced nothing.
32.stands under the chip;1. oneand multi-item lists still draw as lists.Diff is 9 lines in
render.goplus a guard test and a change entry.How it was checked
go test ./internal/tui2/prose -run TestABareNumberedReplyStillDraws -v— new test, fails on the base commit ("32." rendered to nothing), passes with the fix.go test ./internal/tui2/prose— full package green.go vet ./internal/tui2/prose— clean.go build ./...— whole tree builds.32.→[32.]at column 0;1. one→[1. one];1. one\n2. two→ two list rows;32→[32]. Markers for real lists are unchanged.go run ./cmd/codeaf-changes check—12 entries, all well formed.Note:
internal/namelaw's## The namesection test andinternal/tui3'sTestAConversationWithNoTitleIsNamedInWordsNotHexfail on a clean checkout of the base too, so they are pre-existing and unrelated to this change.Checklist
docs/changes/unreleased/1072-bare-number-reply-draws.md..github/known-red.txt.render.go, the new test, and the change entry.Closes #1072.