Skip to content

Message-box parity and visual design rules - #1334

Merged
ZeroPoint95 merged 6 commits into
devfrom
codex/message-box-design-rules
Sep 24, 2026
Merged

Message-box parity and visual design rules#1334
ZeroPoint95 merged 6 commits into
devfrom
codex/message-box-design-rules

Conversation

@ZeroPoint95

@ZeroPoint95 ZeroPoint95 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Separates the proposed standing preferences and design rules from #1071, as requested in Abir's review.

This draft contains the message-box parity preference, hover treatment for clickable Home headings, and model/effort/project presentation rules. The product implementation remains in #1071.

Owner confirmation is required for the standing-rule wording and the dated owner attribution before this draft is merged. The parity preference was explicitly requested in the source conversation; this PR does not presume that the conversation grants repository-wide attribution to another owner.

Validation: make pr-ready passed; documentation-only change, with no Go packages changed.

@ZeroPoint95 ZeroPoint95 mentioned this pull request Sep 21, 2026
Merged
@ZeroPoint95
ZeroPoint95 marked this pull request as ready for review September 21, 2026 19:31
@AbirAbbas @claude
docs: credit the seam rules to #1071, and publish an entry that is true
af17cce 
The model-on-the-seam rule named an owner ruling nobody can point to; the
behaviour it describes is what #1071 shipped and its tests pin, so it is
credited to that pull request instead. The change entry carried a note for
reviewers in `invalidates`, which the changelog publishes as a claim; nothing
anybody believed changed here, so the list is empty and the body says what
lands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@AbirAbbas

AbirAbbas commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

@ZeroPoint95 two things on this one.

I pushed af17cce on top of your branch:

  • The seam rule said "Owner ruling, 2026-09-17", but there's no ruling of mine I can point to behind it. What it describes is exactly what UX changes: home navigation and consistent message-box controls #1071 shipped (TestTheCurrentModelIsBoldAndBrightOnBothSeams, TestTheSeamKeepsTheRiderWithoutTheBranchOrTitle and TestProjectPathsKeepTheirRootsAndTruncateOnTheRight pin it), so I credited it to UX changes: home navigation and consistent message-box controls #1071 instead. The rule itself stays as you wrote it.
  • The change entry had a note for reviewers in invalidates, and the changelog publishes that field in the release notes as a claim. Nothing anybody believed changed here, so it's invalidates: [] now and the body says what lands.

One question for you before this merges: the new CLAUDE.md line under Learned User Preferences. Once it's in, every agent working in this repo will carry a change to Home's message box over to the conversation's message box without asking. Is that meant as a repo-wide rule, or was it a preference from your own session? If it's the latter, drop the line (and the last sentence of the change entry) and this is good to go. Also worth dropping "Proposed" from the title, since it becomes the squash commit message.

@AbirAbbas @claude
docs: the message-box parity preference stays out of CLAUDE.md
0e17c48 
Abir's ruling on #1334: the Home-to-conversation message-box parity line
was a preference from one session, not a rule every agent in this repo
should carry, so it leaves Learned User Preferences and the change entry
no longer announces it. The design rules in DESIGN-LANGUAGE.md stay as
written.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@AbirAbbas AbirAbbas changed the title Proposed message-box parity and visual design rules Message-box parity and visual design rules Sep 24, 2026
@AbirAbbas

AbirAbbas commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

@ZeroPoint95 Abir decided to keep the message-box parity preference out of CLAUDE.md, so it is not a repo-wide rule every agent in this repo carries. The design rules themselves land as you wrote them.

Checked: the DESIGN-LANGUAGE.md rules against the code on dev (heading underline in homecell.go, project: lead in homedraft.go, model (provider):effort on the seam). The three tests that pin them pass: TestTheCurrentModelIsBoldAndBrightOnBothSeams, TestTheSeamKeepsTheRiderWithoutTheBranchOrTitle, TestProjectPathsKeepTheirRootsAndTruncateOnTheRight. make changelog-check and make pr-ready BASE=origin/dev are green on a local merge with dev at 138cda9. CI is green on 0e17c48.

Added:

  • 0e17c48: removes the parity line from Learned User Preferences and the change entry's last sentence about it.

I also dropped "Proposed" from the title.

AbirAbbas
AbirAbbas approved these changes Sep 24, 2026
View reviewed changes

@AbirAbbas AbirAbbas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on top of dev; merging.

@ZeroPoint95
ZeroPoint95 added this pull request to the merge queue Sep 24, 2026
Merged via the queue into dev with commit e3f94b6 Sep 24, 2026
4 checks passed
@ZeroPoint95
ZeroPoint95 deleted the codex/message-box-design-rules branch September 24, 2026 20:35
@AbirAbbas AbirAbbas mentioned this pull request Sep 24, 2026
Merged
AbirAbbas added a commit that referenced this pull request Sep 24, 2026
@AbirAbbas @claude
Merge origin/dev into santos/dev2: Ara's Home, tips and Sessions wave
99ec179 
Brings #1415, #1424, #1425, #1334, #1422, #1388, #1389 and #1426 onto the
integration branch (dev at debffab).

Conflicted files and how each was settled:

- internal/tui3/homeslash.go: the opens-a-conversation fate keeps dev2's
  /skill and dev's /manual and /folder (the union). dev's /project pin and
  the removal of /image and /ask stand. The fate-table and homeTrayCommand
  comments no longer name /image or the old /folder pin.
- internal/manual/chat/home.md: dev's three rows for /attach, the commands
  that open a conversation and the ones that answer on Home, with dev2's
  /skill /skills added to the opens-a-conversation row so the table matches
  homeFate.
- internal/tui3/notice_test.go: both sides appended tests; all are kept
  (dev2's unread and retired profile-key tests, dev's ranking and rotation
  tests). newNoticeBoard's third argument is "hints enabled", so the
  hints-off test still passes false.

Not a textual conflict, but broken by the merge:

- internal/manual/chat/compacting-over-and-over.md: the probe "what
  happened to the earlier messages" reached another page once dev2's pages
  and dev's respelled heading met. The heading carries the phrase again.

Semantic collisions checked with no change needed: Escape and double-space
against dev2's task page, rail, pickers and skill chips; one /skill row and
alias; the tip table (22 rows, no priority column, the unread-keys line is
not a tip and shows with hints disabled); ui.hints stays a read key beside
dev2's task.parallel and retired-key rows; Home's working mark and the
filtered Sessions list against dev2's stopped and interrupted runs; the
attach tray carries files and skill chips side by side; the e2e word table;
system.md; icons and banned words; change entries.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
santoshkumarradha pushed a commit that referenced this pull request Sep 25, 2026
@agentfield-bot
Merge origin/dev into feat/conversation-overview
c6fabef 
Brings in #1410, #1440, #1426, #1389, #1388, #1422, #1334, #1424, #1425
and #1415. Conflicts resolved keeping both sides: the keys row carries
dev's project and low-credit line at its right end and the dock in what
they leave; the strip's home chip takes dev's word on the one top bar's
lead; the chats place joins dev's restored esc and double-space manual.
santoshkumarradha pushed a commit that referenced this pull request Oct 24, 2026
@AbirAbbas @claude
Merge origin/dev into santos/dev2: Ara's Home, tips and Sessions wave
25b431a 
Brings #1415, #1424, #1425, #1334, #1422, #1388, #1389 and #1426 onto the
integration branch (dev at 5289195).

Conflicted files and how each was settled:

- internal/tui3/homeslash.go: the opens-a-conversation fate keeps dev2's
  /skill and dev's /manual and /folder (the union). dev's /project pin and
  the removal of /image and /ask stand. The fate-table and homeTrayCommand
  comments no longer name /image or the old /folder pin.
- internal/manual/chat/home.md: dev's three rows for /attach, the commands
  that open a conversation and the ones that answer on Home, with dev2's
  /skill /skills added to the opens-a-conversation row so the table matches
  homeFate.
- internal/tui3/notice_test.go: both sides appended tests; all are kept
  (dev2's unread and retired profile-key tests, dev's ranking and rotation
  tests). newNoticeBoard's third argument is "hints enabled", so the
  hints-off test still passes false.

Not a textual conflict, but broken by the merge:

- internal/manual/chat/compacting-over-and-over.md: the probe "what
  happened to the earlier messages" reached another page once dev2's pages
  and dev's respelled heading met. The heading carries the phrase again.

Semantic collisions checked with no change needed: Escape and double-space
against dev2's task page, rail, pickers and skill chips; one /skill row and
alias; the tip table (22 rows, no priority column, the unread-keys line is
not a tip and shows with hints disabled); ui.hints stays a read key beside
dev2's task.parallel and retired-key rows; Home's working mark and the
filtered Sessions list against dev2's stopped and interrupted runs; the
attach tray carries files and skill chips side by side; the e2e word table;
system.md; icons and banned words; change entries.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbirAbbas AbirAbbas AbirAbbas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroPoint95 @AbirAbbas