Repository navigation
README: show the pinned-version install line the release test requires - #1103
Merged
Merged
Conversation
The Install rewrite dropped the VERSION=<tag> pin example, and TestPublishedPinExamplesGiveVersionToBash reads every published install surface for `| VERSION=` because `VERSION=<tag> curl ...` is an easy mistake to copy — it sets the variable for curl instead of the install script. The pin goes back inline on the same host the section already uses, with the releases page still linked for tags. Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
santoshkumarradha
added
the
hygiene
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPublishedPinExamplesGiveVersionToBashhas been failing on a cleandevcheckout since the README rewrite (#1049) dropped its pinned-version install example.The test reads every published install surface for
| VERSION=, because the tempting spellingVERSION=<tag> curl ...sets the variable for curl rather than for the install script.docs/rules/promotion.md, the chat manual andrelease.ymlstill show the working form; the README had been reduced to "version pinning is on the releases page".This puts one pin line back in
## Install, on the same host the section already uses, and keeps the releases page linked for tags. README only; the section stays short.Evidence
make checkgreen on this exact head, run on the Spark cluster from a fresh clone ofdadd55c548e11a764e08dcc044e77f118e033e65: 97 packages ok, 0 failures, binary under the size budget.go test ./internal/release/... ./internal/namelaw/...green.🤖 Generated with Claude Code