Repository navigation
do: a node re-dispatched after running out is given more room, never the identical grant - #1098
Closed
santoshkumarradha wants to merge 6 commits into
Closed
santoshkumarradha wants to merge 6 commits into
santoshkumarradha wants to merge 6 commits into
Conversation
Member
Author
|
Hi @AbirAbbas, please review as high priority. |
Member
Author
|
Also |
…om than the attempt that ran out Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
…de took, are readable off the journal Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
…sent round again Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
…ispatched in place Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
Co-Authored-By: codeaf <agentfield-bot@users.noreply.github.com>
santoshkumarradha
force-pushed
the
fix/overrun-regrant
branch
from
September 17, 2026 13:04
85aae36 to
eafafb1
Compare
Member
Author
|
Retargeted to |
Member
Author
|
Correction: the Spark job for this head is |
Member
Author
|
Spark |
santoshkumarradha
marked this pull request as draft
September 17, 2026 14:23
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A plan node that ran out of its token budget was released back to pending and re-dispatched with the byte-identical grant and brief, up to
MaxOverrunRounds, and bought the same truncated ending each time (observed twice in one run, ~12 USD).cmd/codeaf/subharness.go:regrantAfterRunningOutgrows the token grant by three halves per re-dispatch, never aboveoverrunGrantCeiling(four flat leaf grants; a fan-in that measured more keeps every token it measured). Wired at the dispatch grant inchat.go; the leaf's wall follows the larger grant.internal/resident/runner.go: a re-dispatch that banks nothing beyond what the hand-on release journaled (store.ReleasedTurnsFor) is failed with the refusal named (outOfRoomRefusedFailure) instead of sent round again.internal/store/lifecycle.go:ReleasedTurnsFor,NodeRedispatchesread off the journal.--jsonenvelope:redispatches(absent when none), counted per node of the run's own session; manual row added.TestARedispatchIsGrantedMoreRoomThanTheAttemptThatRanOut,TestAnExhaustedRedispatchThatBankedNothingNewFails,TestAnErrandCountsTheRedispatchesItsOwnNodesBought, envelope key test extended. Change note indocs/changes/unreleased/.Verification
Spark job
20260917-094736-000551one689581ea,go test -count=1 ./cmd/codeaf/ ./internal/resident/... ./internal/store/...:The only commit after that head renames the change note to this PR's number. Not merged; awaiting the owner's look.
🤖 Generated with Claude Code