You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
a controller that says nothing fails the hedge fixture by the deadline, not by an assertion naming the silence #971
In the same fixture (#952, theControllersWord in internal/provider/hedge_test.go), a controller that never speaks is not
reported as a controller that never spoke. The lane holds its first word on a
channel that is never closed, the scenario runs to the test's deadline, and what
the reader gets is a timeout naming whichever test was running — the same shape
this pull request was written to remove everywhere else.
Proposal: the hold is bounded by the scenario's own patience, and the silence is
an assertion. theControllersWord (or the rig that hands it out) waits for the
word with a bound tied to the ceiling the scenario set rather than to the
package timeout, and on expiry fails with the sentence — something in the
register of "the controller never spoke: no rung of the waiting ladder was
reported before ", naming the last phase seen. Then a regression that
stops reporting fails on the claim it broke, in one line, instead of on a clock.
Raised by the provider owner's review of #952; deliberately left out of it
because it widens the change.
Drafted with CodeAF · reviewed and owned by the author
Activity