the controller-acted list in the hedge fixture is kept by hand: put it on the phase type beside PhaseNews.Waiting() #970

theControllersWord in internal/provider/hedge_test.go (#952) closes its
signal on a list it keeps by hand:

case PhaseAllSlow, PhaseBelowPace, PhaseSwitching, PhaseSwitchingModel:

That list is "the controller has acted", and it lives nowhere else. #952 already
had to grow it twice: PhaseBelowPace because #924 split control.Report in
two, and PhaseSwitchingModel one rung lower. A controller phase added after
this — or a rung renamed — leaves the fixture silently short, and the way that
failure shows up is a lane holding its first word until the test's deadline,
which names nothing.

The seam is the phase type's own account of itself. internal/provider/phase.go
already answers one question of this shape — PhaseNews.Waiting() says whether
a phase is one a person is waiting through, from a single switch beside the
constants. A sibling ControllerActed() there, with its own comment saying what
counts as the controller having spoken, puts the list where a new phase is
written and makes the fixture read it rather than repeat it. The provider
owner's review of #952 is the right reader for whether the two questions stay
separate or a phase carries both.

No behaviour changes; it is where one fact lives.

Drafted with CodeAF · reviewed and owned by the author