Skip to content

Mac push: Opening a long chat no longer holds ~730 MB (from #2045) #2060

Closed

Description

@AbirAbbas

This draft was closed, unmerged, when the 2026-10-29 Mac stability and performance push was stopped early to save usage. Its branch is kept: reopen the PR or start from the branch, rebase onto the latest base, and finish the steps below.

PR: #2045 (session: an opened chat lets go of the journal lines it replayed)
Branch: perf/engine-long-chat-memory

What it fixes. Opening a 1,376-entry chat made the engine hold ~730 MB (73 MB listed but not opened) and the first page took 1.1 s. The fix, chosen after a heap profile, is in internal/session; there is no wire change.

Done. Heap attribution and the internal/session change.

Left. An s7 before/after plus the long-chat A/B; touched-package and importer gates; a Codex round; CI comparison.


🤖 Generated with Claude Code

Activity

  1. added
    bugSomething the code does that it should not
    area:sessionThe engine — turns, tasks, the toolbelt, checkpoints
    sev:seriousWrong or missing behaviour a person meets in ordinary use
    on Nov 1, 2026
  2. AbirAbbas commented on Nov 2, 2026

    @AbirAbbas
    CollaboratorAuthor

    Merged in #2045 (squash 86ebdda on app/v3), rebased onto app/v3 f7422fb. CI on the rebased head (PR gate and Full check) failed only on tests that also fail on the app/v3 baseline, or that flaked on unrelated branches in the same rounds. Code review of the rebased head: no findings. Not yet exercised on a real Mac: nothing Mac-specific; the long-chat memory reading on the Mac is still to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:sessionThe engine — turns, tasks, the toolbelt, checkpointsbugSomething the code does that it should notsev:seriousWrong or missing behaviour a person meets in ordinary use

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions