🎨 Palette: Improve form input accessibility - #61
Conversation
Co-authored-by: AntonioCardenas <11583391+AntonioCardenas@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for heartfelt-swan-19c038 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
💡 What
Improved the
FormInputcomponent by programmatically associating labels with inputs using React'suseId()and added necessary ARIA attributes to handle validation error states accessibly. Also recorded a critical learning about wrapping UI library elements safely.🎯 Why
Previously,
FormInputinstances did not explicitly linkForm.LabeltoForm.Control, making it difficult for screen readers to associate the correct text with the input field. Additionally, validation errors were displayed visually but lacking ARIA associations (aria-invalid,aria-describedby, androle="alert"), so assistive technologies might silently miss error context.📸 Before/After
Before: Inputs and labels relied on DOM structure alone. Error messages were plain spans.
After: Each instance of
FormInputgenerates a unique ID, linkinghtmlFortoid. Errors setaria-invalid="true", reference the erroridinaria-describedby, and userole="alert".♿ Accessibility
useId.aria-invalidto notify assistive technologies of invalid states.aria-describedbyto link the input directly to the error message.role="alert"to the error message so it is announced immediately when it appears.PR created automatically by Jules for task 10791220984263754587 started by @AntonioCardenas