feat: logo showcase block by BaskarMitrah · Pull Request #708 · AdobeDocs/adp-devsite

BaskarMitrah · 2026-07-23T07:16:35Z

Description

Feat : Partner logo showcase

Jira

https://jira.corp.adobe.com/browse/DEVSITE-2500

Test URL

https://devsite-2500--adp-devsite-stage--adobedocs.aem.page/test/baskar/partnerslogo

Mobile Responsive

Tab Responsive

Accessbility

aem-code-sync · 2026-07-23T07:20:11Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run all PSI checks
Re-run failed PSI checks
Re-sync branch

Commits

819c30a ✅ (latest)
302ec76 ✅
d7dcbe9 ✅
f5a8541 ✅
0684547 ✅
ba2b652 ✅
d7d3282 ✅
fe5a8c8 ✅
5566f39 ✅
38852bc ✅
a107948 ✅

aem-code-sync · 2026-07-23T07:20:31Z

	Page	Scores	Audits	Google
📱	/test/baskar/partnerslogo
🖥️	/test/baskar/partnerslogo

BaskarMitrah · 2026-07-28T11:41:35Z

Accessibility review

Third example on your test page is missing labels for the partner buttons:

since there's no visible labels available you should set one on the button using aria-label;

axe issue: https://axe.deque.com/issues/48387c6a-d5d5-4550-bacc-b71799cce121

Last example has blue link on blue background

axe issue: https://axe.deque.com/issues/f02ff29f-cc03-48ef-be0e-47d669f716db

Missing role or wrong ARIA attribute on video player

axe issue: https://axe.deque.com/issues/86bd141d-97f1-4e29-8b40-1fc035069327

Missing focus ring/underline on anchor tag

I think this is because you added the spectrum-Link classes, try removing them

I looked in Express' docs and those links don't have the classes

No "current" indicator for the text only buttons in the last example

Other issues

Videos keep playing after you switched to a different "item"

this can affect performance

Last example has a slight layout shift when going from the first item to any of the other ones (low priority)

this seems to be because the other items don't have a CTA

I am wondering if this can be prevented

video: https://github.com/user-attachments/assets/768d5a21-f86a-40e9-a45f-8549947e9fc7

Hi @davids-ensemble , I've fixed the AI review comments, resolved the accessibility issues, and tested everything. I've also attached the reference image for your review. Updated this PR with current changes

Regarding the other issue you mentioned, I tested it using a single button in the last example purely for testing purposes(button color). Ideally, the Logo component should have a consistent layout across all items. That means we should either display the button for all cards or remove it from all of them.

This was only for testing, so it won't affect anything. However, if we allow only one card to have a button, it will affect the spacing and alignment of the other cards, making the overall layout look inconsistent.

Reference Accessbility

github-actions · 2026-07-28T15:07:46Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.03%	3873/6674
Branches	86%	559/650
Functions	52.63%	130/247
Lines	58.03%	3873/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	74.35%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	48.61%	95.22%	43.01%	48.61%

Coverage report generated at 2026-07-28T15:07:45.882Z

github-actions · 2026-07-28T15:23:20Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.12%	3879/6674
Branches	86.02%	560/651
Functions	52.63%	130/247
Lines	58.12%	3879/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	74.35%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	48.76%	95.23%	43.01%	48.76%

Coverage report generated at 2026-07-28T15:23:20.562Z

github-actions · 2026-07-28T15:31:55Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.37%	3896/6674
Branches	86.1%	564/655
Functions	53.03%	131/247
Lines	58.37%	3896/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	75%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	49.18%	95.28%	43.54%	49.18%

Coverage report generated at 2026-07-28T15:31:55.212Z

louisachu

@BaskarMitrah I notice that the images/video are being cropped with a gap on the top when resized to tablet view. Please take a look. Also, please remember to add the documentation into our sidekick library as this is a new devbiz component including
any limitation.

github-actions · 2026-07-29T04:28:54Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.12%	3879/6674
Branches	86.02%	560/651
Functions	52.63%	130/247
Lines	58.12%	3879/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	74.35%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	48.76%	95.23%	43.01%	48.76%

Coverage report generated at 2026-07-29T04:28:54.092Z

github-actions · 2026-07-29T04:50:08Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.28%	3890/6674
Branches	86.06%	562/653
Functions	53.03%	131/247
Lines	58.28%	3890/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	74.35%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	49.03%	95.27%	43.54%	49.03%

Coverage report generated at 2026-07-29T04:50:07.746Z

davids-ensemble

This needs to be reworked to implement the Tabs Pattern.

I created a Proof of Concept to show you how the final (simplified) HTML should look like: logo-sowcase-tablist.html

A few things to notice:

the use of roles, ids and aria attributes;
tab order follows pattern requirement with tablist getting focus first;
tablist's location in the DOM is before tabpanel;
the layout is created using grid areas, these can easily be adjusted for breakpoints;
dynamic tabindex on tabs.

My PoC is missing all the interactions that the pattern requires, only click was set up to be a functional demo.

According to the Tabs Pattern these are the minimum requirements:

Pressing the Tab key enters the tablist and focuses the active tab element;
The inactive tab elements have tabindex="-1";
When on a tab element the Left and Right arrow keys move the focus to the previous or the next tab element with looping supported;
When on a tab element, pressing Space or Enter key activates it;
When on a tab element, pressing the Tab key moves focus inside the tabpanel if anything is focusable, otherwise continues on with the next focusable element on the page.

Please go over the resources I've based this review on to understand the pattern:

github-actions · 2026-08-04T05:50:07Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	60.2%	4018/6674
Branches	86.88%	603/694
Functions	56.62%	141/249
Lines	60.2%	4018/6674

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	62.59%	75%	100%	62.59%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	40.65%	100%	50%	40.65%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	56.83%	73.52%	58.33%	56.83%
scripts	51.13%	95.69%	47.84%	51.13%

Coverage report generated at 2026-08-04T05:50:07.278Z

feat : partner logo showcase

a107948

BaskarMitrah requested a review from melissag-ensemble July 23, 2026 07:16

This comment was marked as outdated.

Sign in to view

BaskarMitrah requested a review from louisachu July 28, 2026 07:02

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 28, 2026 07:16 Inactive

rename : logo-showcase

38852bc

This comment was marked as outdated.

Sign in to view

BaskarMitrah changed the title ~~feat : partner logo showcase~~ feat : logo showcase Jul 28, 2026

davids-ensemble self-requested a review July 28, 2026 07:34

davids-ensemble changed the title ~~feat : logo showcase~~ feat: logo showcase Jul 28, 2026

davids-ensemble changed the title ~~feat: logo showcase~~ feat: logo showcase block Jul 28, 2026

davids-ensemble reviewed Jul 28, 2026

View reviewed changes

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 28, 2026 09:13 Inactive

fix : pr comments

5566f39

This comment was marked as outdated.

Sign in to view

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 28, 2026 09:18 Inactive

removed observer

fe5a8c8

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

davids-ensemble approved these changes Jul 28, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 28, 2026 10:36 Inactive

test : Accessibility

d7d3282

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 28, 2026 15:06 Inactive

update : comments

ba2b652

fix : background issue in the navy

0684547

update : css - background color navy text

f5a8541

louisachu reviewed Jul 28, 2026

View reviewed changes

fix : tab responsive issue

d7dcbe9

fix : mobile responsive issue

302ec76

aem-code-sync Bot temporarily deployed to DEVSITE-2500 July 29, 2026 04:49 Inactive

davids-ensemble requested changes Jul 29, 2026

View reviewed changes

Base automatically changed from stage to main July 30, 2026 20:06

rework: implemented the tabs pattern

819c30a

aem-code-sync Bot deployed to DEVSITE-2500 August 4, 2026 05:49 View deployment

davids-ensemble changed the base branch from main to stage August 5, 2026 14:02

davids-ensemble approved these changes Aug 5, 2026

View reviewed changes

BaskarMitrah merged commit 9d96879 into stage Aug 5, 2026
1 of 4 checks passed

Uh oh!

Conversation

BaskarMitrah commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Jira

Test URL

Mobile Responsive

Tab Responsive

Accessbility

Uh oh!

aem-code-sync Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aem-code-sync Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

BaskarMitrah commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions Bot commented Jul 28, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

github-actions Bot commented Jul 28, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

github-actions Bot commented Jul 28, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

louisachu left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 29, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

github-actions Bot commented Jul 29, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

davids-ensemble left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 4, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

Uh oh!

Reviewers

BaskarMitrah commented Jul 23, 2026 •

edited

Loading

aem-code-sync Bot commented Jul 23, 2026 •

edited

Loading

aem-code-sync Bot commented Jul 23, 2026 •

edited

Loading

BaskarMitrah commented Jul 28, 2026 •

edited

Loading