Skip to content

[WE-427] chore: migrate from volta to mise for node version management #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arshabh-agarwal merged 5 commits into from
Jul 16, 2026
+54 −9
Merged

[WE-427] chore: migrate from volta to mise for node version management #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd3b48a
chore: migrate from volta to mise for node version management
arshabh-agarwal Jul 7, 2026
086c2a8
fix(ci): use public jdx/mise-action instead of internal Addepar action
arshabh-agarwal Jul 13, 2026
8b010e6
fix(ci): pin testem below 3.19.0 to avoid ESM execa incompatibility
arshabh-agarwal Jul 13, 2026
7433082
feat: upgrade Node to 24.18.0 and ember-cli to 5.12.0
arshabh-agarwal Jul 13, 2026
91ad5ab
Revert "feat: upgrade Node to 24.18.0 and ember-cli to 5.12.0"
arshabh-agarwal Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Use Volta
uses: volta-cli/action@5c175f92dea6f48441c436471e6479dbc192e194 # v4
- name: Install mise and tools
uses: jdx/mise-action@v4
with:
install: true
cache: true
- name: Enable corepack
run: corepack enable

- name: Node Modules Cache
id: cache-npm
Expand Down Expand Up @@ -73,8 +78,13 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Use Volta
uses: volta-cli/action@5c175f92dea6f48441c436471e6479dbc192e194 # v4
- name: Install mise and tools
uses: jdx/mise-action@v4
with:
install: true
cache: true
- name: Enable corepack
run: corepack enable

- name: Stash yarn.lock for cache key
run: cp yarn.lock __cache-key
Expand Down
32 changes: 32 additions & 0 deletions mise.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[tools]
node = "18.20.5"

[settings.node]
corepack = true
8 changes: 3 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@
"homepage": "https://Addepar.github.io/ember-table",
"resolutions": {
"@ember/test-waiters": "^3.0.2",
"prettier": "1.18.2"
"prettier": "1.18.2",
"testem": "^3.2.0 <3.19.0"
},
"typesVersions": {
"*": {
Expand All @@ -119,8 +120,5 @@
]
}
},
"volta": {
"node": "18.20.5",
"yarn": "1.22.19"
}
"packageManager": "yarn@1.22.19+sha512.ff4579ab459bb25aa7c0ff75b62acebe576f6084b36aa842971cf250a5d8c6cd3bc9420b22ce63c7f93a0857bc6ef29291db39c3e7a23aab5adfd5a4dd6c5d71"
}
Loading