Skip to content

feat: add toast notifications to policy mutation handlers (Closes #240) #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lakes41 merged 1 commit into from
Jul 29, 2026
+17 −0
Merged

feat: add toast notifications to policy mutation handlers (Closes #240) #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/[communitySlug]/admin/policies/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,11 @@ export default function PoliciesPage() {
onSuccess: (data, policy, context) => {
if (data.status === 'pending') {
qc.setQueryData(queryKeys.policies.all(communitySlug), context?.previousPolicies);
addToast({
tone: "warning",
title: "Approval Required",
description: `Policy update for "${policy.resourceId}" has been proposed for approval.`,
});
setSuccessMessage(`Policy update for "${policy.resourceId}" proposed for approval.`);
clearPolicyDraft(policy.resourceId);
clearPolicyDraft("");
Expand All @@ -373,6 +378,11 @@ export default function PoliciesPage() {
return;
}

addToast({
tone: "success",
title: `Policy saved for "${policy.resourceId}"`,
description: `The policy was saved successfully.`,
});
setSuccessMessage(`Policy saved for ${policy.resourceId}.`);
setFormErrors((current) => ({
...current,
Expand Down Expand Up @@ -448,6 +458,13 @@ export default function PoliciesPage() {
.finally(() => {
setIsLoadingConflictData(false);
});
} else if (!(err instanceof AuthError)) {
// Non-auth, non-conflict errors — show a toast with the error message
addToast({
tone: "error",
title: "Failed to save policy",
description: safeErrorMessage(err),
});
}

if (policy?.resourceId) {
Expand Down